Pattern config entities simplified ui by Berdir · Pull Request #115 · md-systems/pathauto

Berdir · 2015-12-31T13:23:08Z

No description provided.

…t on a configuration wizard.

…onding class

… administrative pages over to it.

…e PathautoWidgets to work with the method changes and special casing taxonomy_term entity token logic since it does not properly conform to the rest of core.

…g values

…hips in the UI.

…tity interface and implemented them. Also provided preSave and postLoad overrides for the pathauto pattern entity in order to properly handle expanding and contracting relationship settings.

…n order to populate with appropriate tokens from available relationships.

…ing to the plugin

…ions

…be subclasses of CTools provided classes.

…rait and causes PHP notices

…m edit url

Now that patterns are config entities, the UI tests were failing. On top of that, the Add form has an Ajax interaction to select the pattern type, which is covered too.

* Remove obsolete references. * Adjust functions that changed.

Fix PathautoUiTest test

[#79] Update README.md

Fix form redirection after bulk delete

…ities-simplified-ui

The Drupal 7 version of Pathauto had logic to evaluate a bundle being deleted and see if there were matching patterns that had to be removed as well. This is something that we don't see a real need for. Instead, we will let the site administrator to clean up patterns manually after removing a bundle.

Don't expect Pathauto to delete patterns on bundle deletion

Plus: * Small improvements suggested by Berdir. * Make sure that the langcode is a valid machine-name. For example, Chinese traditional has a langcode zh-hant, which is not valid for a machine name.

[#10] Port patterns from config objects to config entities

juampynr · 2015-12-31T17:59:45Z

👹

How can I help peer reviewing this?

Berdir · 2016-01-01T08:45:36Z

Currently going through and doing some cleanup. Will possibly merge this soon.

Note: I am using the new token entity mapper service. Make sure you are using the latest token 8.x-1.x.

Berdir · 2016-01-01T10:26:38Z

Ok, going to merge this now!

A few follow-ups to work on:

Make pathauto_entity_base_field_info() configurable. Expose a list of checkboxes for each type. Ticking the checkbox should expose that base field for the selected entity types. In case a base field already exists and is not defined by us (e.g. node), it should be checked by default and be disabled. This in turn will then automatically expose a alias type plugin. At this point, we'll have achieved the goal of fully generic and automated integration with any entity type.
Decide about removing or keeping hook_pathauto_pattern_alter(), I'm considering to remove it, we can add it back if there is a use case.
Update and test forum related code
Introduce a method on pattern plugins to react to alias generation, so that we can move the condition code in updateEntityAlias() to a taxonomy term alias type plugin

…ified-ui Pattern config entities

juampynr · 2016-01-01T15:28:34Z

👍 👍 👍 👍 👍 👍 👍 👍 👍

balsama · 2016-01-01T15:50:46Z

Nice! HUGE step in the right direction. Thanks!

EclipseGc and others added 30 commits October 19, 2015 18:09

typo fix

7657d5d

initial commit of config entity to hold pattern settings

abb7881

updating routes and menu entries as well as providing an initial star…

7dc734e

…t on a configuration wizard.

initial addition of "applies" logic to AliasTypeInterface and corresp…

bdd3928

…onding class

massive update that fully enables the wizard process and switches the…

1ca8fdd

… administrative pages over to it.

using mutable version of config object in submit handler, updating th…

23a8976

…e PathautoWidgets to work with the method changes and special casing taxonomy_term entity token logic since it does not properly conform to the rest of core.

fixing the settings for to appropriately retrieve punctuation handlin…

6245f30

…g values

added context definitions to the pathauto entity schema

593ed20

adding relationship routes for adding, editing and deleting relations…

734e9a3

…hips in the UI.

added helper methods for handling contexts to the pathauto pattern en…

641765e

…tity interface and implemented them. Also provided preSave and postLoad overrides for the pathauto pattern entity in order to properly handle expanding and contracting relationship settings.

Adding additional handling to the pattern configuration wizard step i…

993141a

…n order to populate with appropriate tokens from available relationships.

moving to the entity getContexts() method instead of directly delegat…

e595d07

…ing to the plugin

moving to the entity getContexts() method instead of directly delegat…

3322c08

…ing to the plugin

adding a more appropriate label to the derived plugin context definit…

f630a94

…ions

adding support for relationship contexts.

e0681c3

adding the necessary form for adding contexts. These should ultimate …

124c93a

…be subclasses of CTools provided classes.

Merge with md-systems 8.x-1.x

1289a0c

removed the unnecessary menu entry

ea5680b

minimizing the diff from merging

41307c8

removing unnecessary use statements

1e6ad4e

Added ctools dependency for travis

335a118

Remove custom entity delete form, fix permission

c4cfc00

Shorten the config prefix to just pattern

1fd05ed

Remove stringTranslation property in PathautoManager, duplicated by t…

9375459

…rait and causes PHP notices

Remove default config and schema for old patterns file

0dd6a67

Use draggable list builder, add necessary keys, remove need for custo…

9403e55

…m edit url

Remove PathautoPatternsForm

e4cd27b

Remove getPatternDescription()

0345fc0

Remove hardcoded entity alias types

81a4017

Remove NodeAliasTest

f87c390

juampynr and others added 17 commits December 19, 2015 19:21

Fix typo in docblock

4c841b8

Test that the mass delete form redirects correctly

29327b5

Fix PathautoUiTest test

8750f07

Now that patterns are config entities, the UI tests were failing. On top of that, the Add form has an Ajax interaction to select the pattern type, which is covered too.

[#79] Update README.md

387eddb

* Remove obsolete references. * Adjust functions that changed.

Merge pull request #105 from juampynr/fix-ui-tests

8b0b4f0

Fix PathautoUiTest test

Adjust wording for link APIs at README.md

615a633

Merge pull request #106 from juampynr/update-readme

3e692c7

[#79] Update README.md

Merge pull request #99 from juampynr/delete-submit-redirect

fa62702

Fix form redirection after bulk delete

Merge remote-tracking branch 'origin/8.x-1.x' into pattern-config-ent…

ef88f4b

…ities-simplified-ui

Use the appropriate theme call to render link to show token tree

8bba1aa

Set correct weight for page pattern

ce8869a

Merge pull request #109 from juampynr/remove-bundle-delete-logic

d663322

Don't expect Pathauto to delete patterns on bundle deletion

[#10] Port patterns from config objects to config entities

2297ab6

[#10] Add support to port language-dependant patterns

44c3b2f

[#10] Add language context to patterns

4295382

Plus: * Small improvements suggested by Berdir. * Make sure that the langcode is a valid machine-name. For example, Chinese traditional has a langcode zh-hant, which is not valid for a machine name.

Merge pull request #111 from juampynr/110-update-path-patterns

3f3f568

[#10] Port patterns from config objects to config entities

Berdir added 4 commits January 1, 2016 09:17

Remove leftover pattern form

8710697

Fix punctuation settings

3ad217b

Improve documentation, fix plugin dependencies

5512cdc

Use token entity mapper to clean up token mapping code

468a72f

Berdir added a commit that referenced this pull request Jan 1, 2016

Merge pull request #115 from md-systems/pattern-config-entities-simpl…

749e06c

…ified-ui Pattern config entities

Berdir merged commit 749e06c into 8.x-1.x Jan 1, 2016

Berdir mentioned this pull request Jan 1, 2016

Support custom/other entities #41

Closed

juampynr mentioned this pull request Jan 7, 2016

Make pathauto_entity_base_field_info() configurable #124

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pattern config entities simplified ui#115

Pattern config entities simplified ui#115
Berdir merged 76 commits into8.x-1.xfrom
pattern-config-entities-simplified-ui

Berdir commented Dec 31, 2015

Uh oh!

juampynr commented Dec 31, 2015

Uh oh!

Berdir commented Jan 1, 2016

Uh oh!

Berdir commented Jan 1, 2016

Uh oh!

juampynr commented Jan 1, 2016

Uh oh!

balsama commented Jan 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Berdir commented Dec 31, 2015

Uh oh!

juampynr commented Dec 31, 2015

Uh oh!

Berdir commented Jan 1, 2016

Uh oh!

Berdir commented Jan 1, 2016

Uh oh!

juampynr commented Jan 1, 2016

Uh oh!

balsama commented Jan 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants