Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 28, 2025

Overview

This PR enhances the ICookieMgr implementation to cache cookie values when cookies are disabled and automatically write them when cookies are re-enabled through either explicit API calls or dynamic configuration changes. A new disableCookieCache configuration option provides backward compatibility for applications that depend on the previous behavior.

Problem

Previously, when cookies were disabled (either globally or individually), calls to cookieMgr.set() would simply return false and the cookie values would be lost forever. Similarly, cookieMgr.del() operations were ignored when cookies were disabled. This created issues where:

  • Applications would lose important session data during temporary cookie disable periods (e.g., before cookie compliance banner approval)
  • Users who later enabled cookies would have incomplete application state
  • No mechanism existed to recover from temporary cookie blocking scenarios

Solution

Enhanced the cookie manager with intelligent caching behavior while maintaining backward compatibility:

New Caching Behavior (Default)

  • Cookie operations are cached when cookies are disabled instead of being lost
  • Automatic flushing applies cached operations when cookies are re-enabled via setEnabled(true) or dynamic configuration changes
  • Memory-efficient storage using pre-formatted cookie strings and operation enums
  • Privacy compliance - respects existing blocked/ignored cookie policies during caching

Backward Compatibility

  • disableCookieCache configuration option allows reverting to previous behavior where operations return false when disabled
  • Seamless migration - existing applications continue working without changes
  • Comprehensive test coverage validates both new and legacy behaviors

Key Features

  1. Smart caching mechanism: Uses internal storage with operation type tracking (SET/PURGE)
  2. Asynchronous configuration support: Responds to real-time config changes via onConfigChange callback
  3. Performance optimized: Pre-formats cookie values to avoid reconstruction during flushing
  4. Memory management: Proper cleanup prevents memory leaks
  5. Type safety: Full TypeScript support with proper enum usage
  6. Asynchronous flushing: Cached cookies are flushed asynchronously through the dynamic configuration system to ensure deterministic behavior

Configuration

// New behavior (default) - enables caching
const config = {
  cookieCfg: {
    enabled: false,
    disableCookieCache: false  // or omit (defaults to false)
  }
};

// Legacy behavior - disables caching
const config = {
  cookieCfg: {
    enabled: false,
    disableCookieCache: true  // reverts to previous behavior
  }
};

Use Cases

This enhancement particularly benefits applications with:

  • Cookie compliance banners requiring delayed approval
  • Dynamic privacy controls that toggle cookie usage
  • Temporary cookie blocking scenarios (network issues, browser restrictions)
  • Applications needing to preserve state during cookie disable/enable cycles

Technical Implementation

The setEnabled() method now uses asynchronous configuration changes only:

  • Sets cookieMgrConfig.enabled to trigger dynamic config updates
  • Updates legacy disableCookiesUsage flag for backward compatibility
  • Removes synchronous state updates to ensure all changes flow through the unified configuration system
  • Allows the onConfigChange callback to handle enable/disable transitions and cookie flushing consistently

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits July 28, 2025 18:11
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI changed the title [WIP] [Feature] Update the ICookieMgr implementation to write cookies after being enabled [Feature] Implement cookie caching when disabled and automatic flushing when enabled Jul 28, 2025
Copilot AI requested a review from MSNev July 28, 2025 18:19
Copilot finished work on behalf of MSNev July 28, 2025 18:19
@MSNev
Copy link
Collaborator

MSNev commented Jul 28, 2025

it should not rely on the "setEnabled" being called but instead it should handle dynamic changes via the onConfigChange and the _enabled flag. It should handle both scenarios.

Also ensure that you add onConfigChange (dynamic config changes) to the test coverage.

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 28, 2025

it should not rely on the "setEnabled" being called but instead it should handle dynamic changes via the onConfigChange and the _enabled flag. It should handle both scenarios.

Also ensure that you ...

Done! I've updated the implementation to handle dynamic configuration changes via onConfigChange and the _enabled flag, not just explicit setEnabled() calls.

Key changes in commit fab9417:

  1. Extracted flushing logic: Created a reusable _flushPendingCookies() function
  2. Enhanced onConfigChange callback: Now detects when _enabled changes from false to true and automatically flushes cached cookies
  3. Supports both scenarios: Works for both setEnabled(true) calls and dynamic config changes (e.g., config.cookieCfg.enabled = true or config.disableCookiesUsage = false)
  4. Comprehensive test coverage: Added 5 new test cases specifically for dynamic config changes:
    • Basic config change to enable cookies
    • Multiple cached cookies flushed via config change
    • Config changes preserving maxAge/domain/path parameters
    • Legacy disableCookiesUsage configuration support
    • Multiple enable/disable cycles via config changes

The implementation now correctly handles cookie flushing whether cookies are enabled via direct API calls or configuration updates.

Copilot AI changed the title [Feature] Implement cookie caching when disabled and automatic flushing when enabled [Feature] Implement cookie caching when disabled and automatic flushing when enabled via setEnabled() or dynamic config changes Jul 28, 2025
Copilot finished work on behalf of MSNev July 28, 2025 19:24
Copilot AI and others added 2 commits July 28, 2025 20:28
…ormatted values

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI requested a review from MSNev July 28, 2025 20:32
Copilot finished work on behalf of MSNev July 28, 2025 20:32
…ge operation to purge

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI requested a review from MSNev July 28, 2025 20:53
Copilot finished work on behalf of MSNev July 28, 2025 20:53
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI requested a review from MSNev July 28, 2025 21:25
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI requested a review from MSNev August 1, 2025 00:20
@MSNev
Copy link
Collaborator

MSNev commented Aug 1, 2025

fix all of the tests that are failing because of the issue addressed in the last commit

…assertions

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 1, 2025

fix all of the tests that are failing because of the issue addressed in the last commit

Fixed all cookie manager tests that were failing due to order-dependent assertions. The issue was that tests expected exact cookie string matches with specific parameter ordering (like "domain=X; path=/"), but the cookie manager's _formatCookieValue function uses objForEachKey which doesn't guarantee property iteration order.

Updated 30+ test assertions to check for individual cookie components separately instead of expecting specific ordering - same validation coverage but order-independent. Fixed in commit f42455c.

… assertions

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Copilot AI requested a review from MSNev August 1, 2025 17:58
@MSNev MSNev force-pushed the copilot/fix-2631 branch from aafdfee to 8f708bc Compare August 2, 2025 00:52
@MSNev MSNev marked this pull request as ready for review August 2, 2025 00:53
@MSNev MSNev enabled auto-merge (squash) August 2, 2025 00:55
@MSNev MSNev force-pushed the copilot/fix-2631 branch 3 times, most recently from 989dbbe to 6fc2f54 Compare August 4, 2025 17:26
@MSNev MSNev force-pushed the copilot/fix-2631 branch from 6fc2f54 to ac768fd Compare August 4, 2025 17:49
@MSNev MSNev merged commit 388ad52 into main Aug 4, 2025
9 checks passed
@MSNev MSNev deleted the copilot/fix-2631 branch August 4, 2025 19:54
MSNev added a commit that referenced this pull request Sep 3, 2025
* Add Azure API Management proxy documentation to FAQ sections (#2625)

* Initial plan

* Add Azure APIM proxy documentation to FAQ sections

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update APIM proxy link text for clarity and consistency

Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>

* Add weekly GitHub action to delete closed and merged branches (#2627)

* Initial plan

* Add weekly GitHub action to delete closed and merged branches

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation and comments to branch cleanup workflow

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add beta and otel-sdk to protected branches list

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comment for GitHub context variables and environment variables

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comment for GitHub API delete reference command

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix wildcard pattern matching in branch protection logic

Replace case statement with [[ ]] pattern matching to properly support
wildcard patterns in variables. Add documentation explaining why this
approach is needed for patterns like "release*" and "*-legacy".

Addresses feedback about wildcard pattern matching not working correctly.

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comments for required workflow permissions

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix trackPageView not resetting maxAjaxCallsPerView counter (#2595)

* Initial plan

* Implement resetAjaxAttempts functionality

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Refactor: Create helper function for resetting ajax attempts counter

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert ajax.ts helper function, create helper in AnalyticsPlugin.ts instead

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Replace direct _trackAjaxAttempts assignments with helper function calls

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove comment and redundant _resetAjaxAttempts call from trackPageView

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Improve test consistency by matching existing test patterns

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add @microsoft/applicationinsights-dependencies-js as dev dependency

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix getPlugin usage to properly access plugin through ILoadedPlugin interface

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove explicit type casting from getPlugin call

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove unused imports IDependenciesPlugin and ILoadedPlugin

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix IDependenciesPlugin interface to extend IPlugin for proper getPlugin typing

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Create IAjaxMonitorPlugin interface and revert Version line per review feedback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Move resetAjaxAttempts method to IAjaxMonitorPlugin interface per review feedback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix npm build failures by removing typed import dependency

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix TypeScript configuration by removing deprecated suppressImplicitAnyIndexErrors option

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix getPlugin typing to use IAjaxMonitorPlugin for proper TypeScript inference

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert tsconfig.json change to restore suppressImplicitAnyIndexErrors

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix IAjaxMonitorPlugin export and plugin access pattern for resetAjaxAttempts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert tsconfig.json change to restore suppressImplicitAnyIndexErrors option

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix jq syntax error in Delete Merged Branches workflow (#2630)

* Initial plan

* Fix jq syntax error in Delete Merged Branches workflow

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update all jq commands to single lines to avoid line splitting issues

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix closed_prs jq command to single line format

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update Async Tests Under AISKULight to Use the Modern AsyncQueue Pattern (#2607)

* Initial plan

* Update async tests in AISKULight to use modern asyncQueue pattern

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Update AISKULight async tests to follow the suggested modern pattern with helper methods

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Remove changes outside AISKULight directory as requested

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add() for waitForException calls in AISKULight tests

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Move initial test setup code before asyncQueue return statement for better variable scoping

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Remove custom helper methods and use PollingAssert.createPollingAssert directly

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Fix async tests by replacing createPollingAssert with asyncTaskPollingAssert for modern pattern compatibility

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add for PollingAssert.asyncTaskPollingAssert on line 167

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add for PollingAssert.asyncTaskPollingAssert on line 210

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* fix: change .concat to .add on line 119 in dynamicconfig.tests.ts

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Fix flush method root cause - handle async callbacks in _doSend with proper error handling (#2633)

* Initial plan

* Fix flush method to handle callbacks and return promises correctly

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Clean up eslint warnings and add comprehensive tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Simplify flush implementation per feedback - handle callbacks and promises correctly when triggerSend returns null

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix root cause in _doSend and use doAwaitResponse in flush method

- Fixed _doSend to properly capture and return promises from sendPostFunc instead of always returning null
- Updated flush method to use doAwaitResponse pattern as suggested
- Ensures async operations properly return promises that can be awaited
- Maintains backward compatibility with existing usage patterns

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix async callback handling in _doSend and simplify flush return logic

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix async callback handling with direct resolve capture instead of polling

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Handle rejection in async preparePayload callback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Use doAwait with direct callbacks instead of doAwaitResponse

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix TypeScript compilation errors in Sender.ts - fix flush method signature and type casting

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Rename flush parameter from 'async' to 'isAsync' to avoid keyword conflicts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add unreleased changes entry to RELEASES.md for flush method fix

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Address code review feedback: clarify breaking changes and add comprehensive flush method tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Use isPromiseLike and isUndefined helpers in Sender tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix flush method to return promise when async=true and no callback provided

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix RELEASES.md to show real original flush method signature

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix issue #2634 moving the conditional check for filtering (#2635)

* Fix issue #2634 moving the conditional check for filtering

* refactoring

* Remove additional unnecessary returns

---------

Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>

* Ensure parent is defined before checking length in getImageHref function (#2636)

Co-authored-by: pnoodles <git@pnoodles.com>

* [Feature] Implement cookie caching when disabled and automatic flushing when enabled with backward compatibility option (#2632)

* Initial plan
* Implement cookie caching when disabled and flushing when enabled
* Fix blocked cookie caching logic - blocked cookies should not be cached
* Add dynamic config change support for cookie flushing
* Address PR feedback: remove redundant flush, cache deletions, store formatted values
* Add test coverage for deletion caching behavior
* Address PR feedback: rename function, eliminate redundant calls, change operation to purge
* Rename helper function to avoid recursive call - _formatSetCookieValue
* Revert del() to use _formatCookieValue instead of _formatSetCookieValue
* Minify cache object by using single-character property names and integer enum constants
* Convert PENDING_OP constants to const enum ePendingOp
* Fix cache object interface: type o as ePendingOp, remove unused p property
* Fix TypeScript error: use _formatCookieValue instead of _formatSetCookieValue in del() caching
* Extract common deletion values creation logic to reduce duplication
* Refactor _createDeletionValues to _formatDeletionValue and simplify call sites
* Update tests to reflect new cookie caching behavior when disabled
* Add clock.tick(1) after configuration changes to allow dynamic config updates
* Fix failing tests: Replace throw patterns with call counters in disabled cookie tests
* Revert disabled cookie tests to use throw pattern instead of call counters for tests that never enable cookies
* Fix cookie flushing order issue in setEnabled() method
* Revert "Fix cookie flushing order issue in setEnabled() method"
  - This reverts commit 8da53ab.
* Fix failing tests by adding clock.tick(1) after setEnabled() calls to allow async config changes
* Add release notes for cookie caching feature to RELEASES.md
* Add disableCaching configuration option and comprehensive test coverage
* Implement PR review feedback: rename disableCaching to disableCookieCache, add @SInCE tag, optimize with local variable, set default to false
* Simplify disableCookieCache configuration to use direct false value
* Fix test failures by adding useFakeTimers: true to all tests using clock.tick()
* Fix test failures by adding defensive null checks for this.clock.tick() calls
* Revert defensive clock.tick() helper - ensure tests use useFakeTimers property
* Fix tests to expect new disableCookieCache configuration property
* Fix cookie flushing issue in setEnabled method - add immediate flushing for synchronous calls
* Fix setEnabled method to use asynchronous configuration changes and update test with missing clock.tick
* Fix test failures by adding clock.tick() after setEnabled(false) calls in all tests using fake timers
* Fix test delCookie mock to set deletion value instead of deleting entry
* Revert delCookie mock to use delete and fix tests to expect undefined after deletion
* Fix test formatting error in cookie manager tests - proper validation of maxAge cookie flushing
* Fix failing cookie manager tests - correct caching behavior expectations
* Fix cookie manager tests to be order-independent for multi-parameter assertions
* Fix cookie manager tests to handle order-independent cookie parameter assertions
* Take Over co-pilot PR to Fix tests and change name to disableCookieDefer

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* [Main][Task] 34470593: Update AISKU Async Tests To Use the Modern AsyncQueue Pattern (#2637)

* update aisku tests

* udpate

* [Main][Task] 34470593: Update Async Tests Under Dependencies Extension To Use the Modern AsyncQueue Pattern (#2638)

* udpate

* merge main

* [Beta] Fix Merge issues

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>
Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: aimbrenda <120031791+aimbrenda@users.noreply.github.com>
Co-authored-by: Patrick <pnoodles@users.noreply.github.com>
Co-authored-by: pnoodles <git@pnoodles.com>
MSNev added a commit that referenced this pull request Sep 3, 2025
* [Main] Update the copilot instructions (#2617)

* [WIP] [Task] Add tree-shaking annotations (#2616)

* Initial plan

* Changes before error encountered

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix tree-shaking annotation syntax - remove incorrect parentheses

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add parentheses around @__PURE__ comments in IOfflineBatch.ts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add parentheses around @__PURE__ comments for proper TypeScript handling

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Suppressed credentials inline to avoid credscan false positive (#2622)

* Suppressed credentials inline to avoid credscan false positive

* Used the next line supression syntax to avoid long length issue

* [Beta] Add W3c Trace State support / handling and refactor distributed trace... (#2620)

* [Beta] Add W3c Trace State support / handling and refactor distributed trace handling to prepare for OptenTelemetry Span style API / management

* Minification improvements

* [Beta] Merge Main to Beta (#2640)

* Add Azure API Management proxy documentation to FAQ sections (#2625)

* Initial plan

* Add Azure APIM proxy documentation to FAQ sections

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update APIM proxy link text for clarity and consistency

Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>

* Add weekly GitHub action to delete closed and merged branches (#2627)

* Initial plan

* Add weekly GitHub action to delete closed and merged branches

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation and comments to branch cleanup workflow

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add beta and otel-sdk to protected branches list

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comment for GitHub context variables and environment variables

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comment for GitHub API delete reference command

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix wildcard pattern matching in branch protection logic

Replace case statement with [[ ]] pattern matching to properly support
wildcard patterns in variables. Add documentation explaining why this
approach is needed for patterns like "release*" and "*-legacy".

Addresses feedback about wildcard pattern matching not working correctly.

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add documentation comments for required workflow permissions

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix trackPageView not resetting maxAjaxCallsPerView counter (#2595)

* Initial plan

* Implement resetAjaxAttempts functionality

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Refactor: Create helper function for resetting ajax attempts counter

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert ajax.ts helper function, create helper in AnalyticsPlugin.ts instead

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Replace direct _trackAjaxAttempts assignments with helper function calls

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove comment and redundant _resetAjaxAttempts call from trackPageView

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Improve test consistency by matching existing test patterns

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add @microsoft/applicationinsights-dependencies-js as dev dependency

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix getPlugin usage to properly access plugin through ILoadedPlugin interface

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove explicit type casting from getPlugin call

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Remove unused imports IDependenciesPlugin and ILoadedPlugin

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix IDependenciesPlugin interface to extend IPlugin for proper getPlugin typing

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Create IAjaxMonitorPlugin interface and revert Version line per review feedback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Move resetAjaxAttempts method to IAjaxMonitorPlugin interface per review feedback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix npm build failures by removing typed import dependency

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix TypeScript configuration by removing deprecated suppressImplicitAnyIndexErrors option

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix getPlugin typing to use IAjaxMonitorPlugin for proper TypeScript inference

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert tsconfig.json change to restore suppressImplicitAnyIndexErrors

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix IAjaxMonitorPlugin export and plugin access pattern for resetAjaxAttempts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Revert tsconfig.json change to restore suppressImplicitAnyIndexErrors option

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix jq syntax error in Delete Merged Branches workflow (#2630)

* Initial plan

* Fix jq syntax error in Delete Merged Branches workflow

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update all jq commands to single lines to avoid line splitting issues

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix closed_prs jq command to single line format

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Update Async Tests Under AISKULight to Use the Modern AsyncQueue Pattern (#2607)

* Initial plan

* Update async tests in AISKULight to use modern asyncQueue pattern

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Update AISKULight async tests to follow the suggested modern pattern with helper methods

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Remove changes outside AISKULight directory as requested

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add() for waitForException calls in AISKULight tests

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Move initial test setup code before asyncQueue return statement for better variable scoping

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Remove custom helper methods and use PollingAssert.createPollingAssert directly

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Fix async tests by replacing createPollingAssert with asyncTaskPollingAssert for modern pattern compatibility

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add for PollingAssert.asyncTaskPollingAssert on line 167

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Replace .concat with .add for PollingAssert.asyncTaskPollingAssert on line 210

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* fix: change .concat to .add on line 119 in dynamicconfig.tests.ts

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>

* Fix flush method root cause - handle async callbacks in _doSend with proper error handling (#2633)

* Initial plan

* Fix flush method to handle callbacks and return promises correctly

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Clean up eslint warnings and add comprehensive tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Simplify flush implementation per feedback - handle callbacks and promises correctly when triggerSend returns null

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix root cause in _doSend and use doAwaitResponse in flush method

- Fixed _doSend to properly capture and return promises from sendPostFunc instead of always returning null
- Updated flush method to use doAwaitResponse pattern as suggested
- Ensures async operations properly return promises that can be awaited
- Maintains backward compatibility with existing usage patterns

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix async callback handling in _doSend and simplify flush return logic

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix async callback handling with direct resolve capture instead of polling

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Handle rejection in async preparePayload callback

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Use doAwait with direct callbacks instead of doAwaitResponse

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix TypeScript compilation errors in Sender.ts - fix flush method signature and type casting

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Rename flush parameter from 'async' to 'isAsync' to avoid keyword conflicts

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Add unreleased changes entry to RELEASES.md for flush method fix

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Address code review feedback: clarify breaking changes and add comprehensive flush method tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Use isPromiseLike and isUndefined helpers in Sender tests

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix flush method to return promise when async=true and no callback provided

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix RELEASES.md to show real original flush method signature

Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* Fix issue #2634 moving the conditional check for filtering (#2635)

* Fix issue #2634 moving the conditional check for filtering

* refactoring

* Remove additional unnecessary returns

---------

Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>

* Ensure parent is defined before checking length in getImageHref function (#2636)

Co-authored-by: pnoodles <git@pnoodles.com>

* [Feature] Implement cookie caching when disabled and automatic flushing when enabled with backward compatibility option (#2632)

* Initial plan
* Implement cookie caching when disabled and flushing when enabled
* Fix blocked cookie caching logic - blocked cookies should not be cached
* Add dynamic config change support for cookie flushing
* Address PR feedback: remove redundant flush, cache deletions, store formatted values
* Add test coverage for deletion caching behavior
* Address PR feedback: rename function, eliminate redundant calls, change operation to purge
* Rename helper function to avoid recursive call - _formatSetCookieValue
* Revert del() to use _formatCookieValue instead of _formatSetCookieValue
* Minify cache object by using single-character property names and integer enum constants
* Convert PENDING_OP constants to const enum ePendingOp
* Fix cache object interface: type o as ePendingOp, remove unused p property
* Fix TypeScript error: use _formatCookieValue instead of _formatSetCookieValue in del() caching
* Extract common deletion values creation logic to reduce duplication
* Refactor _createDeletionValues to _formatDeletionValue and simplify call sites
* Update tests to reflect new cookie caching behavior when disabled
* Add clock.tick(1) after configuration changes to allow dynamic config updates
* Fix failing tests: Replace throw patterns with call counters in disabled cookie tests
* Revert disabled cookie tests to use throw pattern instead of call counters for tests that never enable cookies
* Fix cookie flushing order issue in setEnabled() method
* Revert "Fix cookie flushing order issue in setEnabled() method"
  - This reverts commit 8da53ab.
* Fix failing tests by adding clock.tick(1) after setEnabled() calls to allow async config changes
* Add release notes for cookie caching feature to RELEASES.md
* Add disableCaching configuration option and comprehensive test coverage
* Implement PR review feedback: rename disableCaching to disableCookieCache, add @SInCE tag, optimize with local variable, set default to false
* Simplify disableCookieCache configuration to use direct false value
* Fix test failures by adding useFakeTimers: true to all tests using clock.tick()
* Fix test failures by adding defensive null checks for this.clock.tick() calls
* Revert defensive clock.tick() helper - ensure tests use useFakeTimers property
* Fix tests to expect new disableCookieCache configuration property
* Fix cookie flushing issue in setEnabled method - add immediate flushing for synchronous calls
* Fix setEnabled method to use asynchronous configuration changes and update test with missing clock.tick
* Fix test failures by adding clock.tick() after setEnabled(false) calls in all tests using fake timers
* Fix test delCookie mock to set deletion value instead of deleting entry
* Revert delCookie mock to use delete and fix tests to expect undefined after deletion
* Fix test formatting error in cookie manager tests - proper validation of maxAge cookie flushing
* Fix failing cookie manager tests - correct caching behavior expectations
* Fix cookie manager tests to be order-independent for multi-parameter assertions
* Fix cookie manager tests to handle order-independent cookie parameter assertions
* Take Over co-pilot PR to Fix tests and change name to disableCookieDefer

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>

* [Main][Task] 34470593: Update AISKU Async Tests To Use the Modern AsyncQueue Pattern (#2637)

* update aisku tests

* udpate

* [Main][Task] 34470593: Update Async Tests Under Dependencies Extension To Use the Modern AsyncQueue Pattern (#2638)

* udpate

* merge main

* [Beta] Fix Merge issues

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>
Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: aimbrenda <120031791+aimbrenda@users.noreply.github.com>
Co-authored-by: Patrick <pnoodles@users.noreply.github.com>
Co-authored-by: pnoodles <git@pnoodles.com>

* [OTel-Sdk] Update shrinkwrap from merge

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rads-1996 <radsg.1996@gmail.com>
Co-authored-by: rads-1996 <22488539+rads-1996@users.noreply.github.com>
Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: aimbrenda <120031791+aimbrenda@users.noreply.github.com>
Co-authored-by: Patrick <pnoodles@users.noreply.github.com>
Co-authored-by: pnoodles <git@pnoodles.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants