Update Async Tests Under AISKULight to Use the Modern AsyncQueue Pattern

[Copilot]

This PR updates all async unit tests in the AISKULight directory to use the modern _asyncQueue pattern instead of the deprecated testCaseAsync pattern, as referenced in PR #2544.

Changes Made

Updated 3 async tests in /AISKULight/Tests/Unit/src/dynamicconfig.tests.ts:

1. "Init: init with cs promise" - Test for initializing ApplicationInsights with a connection string promise
2. "zip test: gzip encode is working and content-encode header is set (feature opt-in)" - Test for gzip encoding when feature is enabled
3. "zip test: gzip encode will not working (feature opt-in is not set)" - Test for no gzip encoding when feature is disabled

Migration Details

Before (deprecated pattern):

this.testCaseAsync({
    name: "test name",
    stepDelay: 100,
    useFakeTimers: true,
    steps: [() => {
        // setup code
    }].concat(PollingAssert.createPollingAssert(() => {
        // polling logic
        return condition;
    }, "message", 60, 1000) as any)
});

After (modern pattern):

this.testCase({
    name: "test name", 
    useFakeTimers: true,
    test: () => {
        // setup code
        
        return this._asyncQueue()
            .concat(PollingAssert.asyncTaskPollingAssert(() => {
                // polling logic
                return condition;
            }, "message", 60, 1000));
    }
});

Key Changes:

• ✅ Replaced testCaseAsync with testCase
• ✅ Removed stepDelay and steps array properties
• ✅ Added return this._asyncQueue() from test functions
• ✅ Chained async operations with .concat()
• ✅ Replaced PollingAssert.createPollingAssert() with PollingAssert.asyncTaskPollingAssert()
• ✅ Preserved all existing test logic and assertions

All deprecated async test patterns have been successfully removed from AISKULight, bringing the test suite in line with modern testing practices for better performance and error handling.

Fixes #2606.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• accounts.google.com
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=4560 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,13082154846606210642,11945895185640804616,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync --enable-automation --export-tagged-pdf --force-color-profile=srgb --generate-pdf-document-outline --metrics-recording-only --no-first-run --password-store=basic --use-mock-keychain --disable-features=Translate,AcceptCHFrame,MediaRouter,OptimizationHints,ProcessPerSiteUpToMainFrameThreshold,IsolateSandboxedIframes --enable-features=PdfOopif --headless=new --hide-scrollbars --mute-audio --disable-extensions --enable-precise-memory-info --expose-internals-for-testing --no-sandbox --remote-debugging-port=0 --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl about:blank (dns block)
• clients2.google.com
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=4560 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,13082154846606210642,11945895185640804616,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync --enable-automation --export-tagged-pdf --force-color-profile=srgb --generate-pdf-document-outline --metrics-recording-only --no-first-run --password-store=basic --use-mock-keychain --disable-features=Translate,AcceptCHFrame,MediaRouter,OptimizationHints,ProcessPerSiteUpToMainFrameThreshold,IsolateSandboxedIframes --enable-features=PdfOopif --headless=new --hide-scrollbars --mute-audio --disable-extensions --enable-precise-memory-info --expose-internals-for-testing --no-sandbox --remote-debugging-port=0 --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl about:blank (dns block)
• www.google.com
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=4560 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,13082154846606210642,11945895185640804616,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-138.0.7204.92/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync --enable-automation --export-tagged-pdf --force-color-profile=srgb --generate-pdf-document-outline --metrics-recording-only --no-first-run --password-store=basic --use-mock-keychain --disable-features=Translate,AcceptCHFrame,MediaRouter,OptimizationHints,ProcessPerSiteUpToMainFrameThreshold,IsolateSandboxedIframes --enable-features=PdfOopif --headless=new --hide-scrollbars --mute-audio --disable-extensions --enable-precise-memory-info --expose-internals-for-testing --no-sandbox --remote-debugging-port=0 --user-data-dir=/tmp/puppeteer_dev_chrome_profile-jqfz1t --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl about:blank (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Karlie-777]

change pattern:
before:

this.testCaseAsync({
    name: "Test name",
    stepDelay: 100,
    useFakeTimers: true,
    steps: [() => {
        // Test setup
    }].concat(this.asserts(1))
    .concat(() => {
        // Additional assertions
    })
});

after:

this.testCase({
    name: "Test name",
    useFakeTimers: true,
    test: () => {
        return this._asyncQueue().add(() => {
            // Test setup
            // ...
        })
        .concat(this.waitForException(1))
        .add(() => {
            // Assertions
            // ...
        });
    }
})

[Copilot]

change pattern:
before:

...

Updated the async tests to follow the pattern you suggested. Added helper methods asserts() and waitForException() and restructured the tests to use the .add() → .concat() → .add() pattern for better separation of setup, polling, and assertions phases. The changes are in commit 5873ab4.

[Karlie-777]

remove all changes are not under AISKULight directory

[Copilot]

remove all changes are not under AISKULight directory

Removed all changes outside the AISKULight directory as requested. The commit 362c9e5 reverts all files that were modified outside of AISKULight back to their original state, keeping only the async test modernization changes within AISKULight/Tests/Unit/src/dynamicconfig.tests.ts.

[Karlie-777]

for the original code before .concat, put them before return this._asyncQueue().add. The first step of each test should be part of the initial test function, So that all subsequent steps have access to the variables and values from this initial step for any additional context

[Karlie-777]

use PollingAssert.createPollingAssert or the original asserts from the current test framework and remove private asserts and private waitForException functions

[Copilot]

for the original code before .concat, put them before return this._asyncQueue().add. The first step of each test should be part of the initial test function, So that all subsequent steps have access t...

Moved the initial test setup code before the return this._asyncQueue() statement in all three async tests. Now variables like this.genericSpy, configuration objects, and telemetry items are initialized in the main test function scope and accessible to all subsequent async steps. Commit 0eef618.

[Copilot]

fix test error:

Message: global failure: TypeError: nextTestStep is not a function
Actual: undefined
...

Fixed the nextTestStep is not a function error by replacing PollingAssert.createPollingAssert() with PollingAssert.asyncTaskPollingAssert() in both async tests. The issue was using the old pattern method with the new _asyncQueue() pattern. Commit e3b4e96.

[Copilot]

Pull Request Overview

This PR modernizes async unit tests in AISKULight by migrating from the deprecated testCaseAsync pattern to the modern _asyncQueue pattern. The update improves test performance and error handling by using a more efficient asynchronous testing approach.

Key changes:

• Replaced deprecated testCaseAsync with modern testCase pattern
• Updated polling assertions to use PollingAssert.asyncTaskPollingAssert()
• Restructured test logic to use _asyncQueue() with chained .add() operations