Breaking Change: Updating async methods to follow C# async naming conventions by hpsin · Pull Request #188 · microsoft/WindowsDevicePortalWrapper

hpsin · 2016-10-11T00:19:27Z

And updating version number. This handles #183

…ventions And updating version number.

msftclas · 2016-10-11T00:19:32Z

Hi @hpsin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Hirsch Singhal). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

MattHyman · 2016-10-11T00:34:29Z


        /// <summary>
-        /// Delete all tags from the device's DNS-SD broadcast. 
+        /// DeleteAsync all tags from the device's DNS-SD broadcast. 


Should this just be "Delete"?

MattHyman · 2016-10-11T00:34:59Z


        /// <summary>
-        /// Delete a specific tag from the device's DNS-SD broadcast. 
+        /// DeleteAsync a specific tag from the device's DNS-SD broadcast. 


Should this also just be "Delete"?

MattHyman · 2016-10-11T00:38:39Z

            /// Gets or sets if the user should be deleted
            /// </summary>
-            [DataMember(Name = "Delete", EmitDefaultValue = false)]
+            [DataMember(Name = "DeleteAsync", EmitDefaultValue = false)]


Just "Delete" here.

hpsin · 2016-10-11T00:40:20Z

This set I purposefully kept as *Async, since it’s the implementation of a required method.

From: Matt Hyman [mailto:notifications@github.com]
Sent: Monday, October 10, 2016 5:39 PM
To: Microsoft/WindowsDevicePortalWrapper WindowsDevicePortalWrapper@noreply.github.com
Cc: Hirsch Singhal hirsin@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [Microsoft/WindowsDevicePortalWrapper] Breaking Change: Updating async methods to follow C# async naming conventions (#188)

@MattHyman commented on this pull request.

In WindowsDevicePortalWrapper/WindowsDevicePortalWrapper.UniversalWindows/HttpRest/RestDelete.cshttps://github.com//pull/188#pullrequestreview-3596542:

@@ -18,7 +18,7 @@

namespace Microsoft.Tools.WindowsDevicePortal

{

 /// <content>

/// Universal Windows Platform implementation of HTTP Delete
/// Universal Windows Platform implementation of HTTP DeleteAsync

Just "Delete" here.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/188#pullrequestreview-3596542, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABltOw22Ed1iyTryLb7qb3kB8araDGnkks5qytq1gaJpZM4KTHhc.

MattHyman

Some minor editing errors on a few comments, but the code looks good to me.

MattHyman · 2016-10-11T00:44:56Z

Hirsch,

I actually deleted that comment shortly after creating it because I caught what you discussed below. Sorry for the noise.

Thanks,

Matt

From: Hirsch Singhal [mailto:notifications@github.com]
Sent: Monday, October 10, 2016 5:40 PM
To: Microsoft/WindowsDevicePortalWrapper WindowsDevicePortalWrapper@noreply.github.com
Cc: Matt Hyman mathy@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [Microsoft/WindowsDevicePortalWrapper] Breaking Change: Updating async methods to follow C# async naming conventions (#188)

This set I purposefully kept as *Async, since it’s the implementation of a required method.

From: Matt Hyman [mailto:notifications@github.com]
Sent: Monday, October 10, 2016 5:39 PM
To: Microsoft/WindowsDevicePortalWrapper <WindowsDevicePortalWrapper@noreply.github.com mailto:WindowsDevicePortalWrapper@noreply.github.com>
Cc: Hirsch Singhal <hirsin@microsoft.com mailto:hirsin@microsoft.com>; Mention <mention@noreply.github.com mailto:mention@noreply.github.com>
Subject: Re: [Microsoft/WindowsDevicePortalWrapper] Breaking Change: Updating async methods to follow C# async naming conventions (#188)

@MattHyman commented on this pull request.

In WindowsDevicePortalWrapper/WindowsDevicePortalWrapper.UniversalWindows/HttpRest/RestDelete.cshttps://github.com//pull/188#pullrequestreview-3596542:

@@ -18,7 +18,7 @@

namespace Microsoft.Tools.WindowsDevicePortal

{

///

/// Universal Windows Platform implementation of HTTP Delete
/// Universal Windows Platform implementation of HTTP DeleteAsync

Just "Delete" here.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/188#pullrequestreview-3596542, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABltOw22Ed1iyTryLb7qb3kB8araDGnkks5qytq1gaJpZM4KTHhc.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/188#issuecomment-252782248, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABc0YwH9B7o8WaJU9aGvozJ7b2wQsuXOks5qytr1gaJpZM4KTHhc.

* DeviceLab sample * This is what I showed to Dave * Committing so that I can change machines and not loose my work * Added a bunch of finishing touches * Latest polish * Added a nifty CommandSequence class * Implemented a nifty CommandSequence class and then used it for the DevicePortalCommand model * Code cleanup + style cop. Checking in for demo * Finished satisfyint StyleCop * Committing before merging changes from upstream * Integrated the new DeviceSignIn view. Fixed the timing issue in the reestablish connection retry loop. Made rename more robust. Stronger check for duplicates using the cannonical IP address * Renamed DeviceLab to SampleDeviceCollection * Added finishing touches to the code. Getting it ready for a pull request * Breaking Change: Updating async methods to follow C# async naming conventions (#188) And updating version number. * Update calls into the wrapper to use the latest async naming convention * Not tracking sync.cmd * Ended up with a stray orig file. Deleting * Change array return types to Lists for #189 (#191) * App, process, and crash dump collection APIs (#193) * Add usermode crash dump APIs * Additional fixes to DumpCollection * Add kernel, live, and app dump APIs. * StyleCop pass

Breaking Change: Updating async methods to follow C# async naming con…

d2a3ca8

…ventions And updating version number.

msftclas added the cla-not-required label Oct 11, 2016

hpsin assigned MattHyman, david-c-kline and WilliamsJason Oct 11, 2016

hpsin added this to the 1.0 Release milestone Oct 11, 2016

MattHyman reviewed Oct 11, 2016

View reviewed changes

MattHyman approved these changes Oct 11, 2016

View reviewed changes

Comment errors in async change

d5ea264

hpsin merged commit cfa9144 into master Oct 11, 2016

hpsin deleted the iss183 branch October 11, 2016 16:20

hpsin mentioned this pull request Oct 11, 2016

Async suffix required for all asynchronous methods #183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Breaking Change: Updating async methods to follow C# async naming conventions#188

Breaking Change: Updating async methods to follow C# async naming conventions#188
hpsin merged 2 commits into
masterfrom
iss183

hpsin commented Oct 11, 2016

Uh oh!

msftclas commented Oct 11, 2016

Uh oh!

MattHyman Oct 11, 2016

Uh oh!

MattHyman Oct 11, 2016

Uh oh!

MattHyman Oct 11, 2016

Uh oh!

hpsin commented Oct 11, 2016

Uh oh!

MattHyman left a comment

Uh oh!

MattHyman commented Oct 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

hpsin commented Oct 11, 2016

Uh oh!

msftclas commented Oct 11, 2016

Uh oh!

MattHyman Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

MattHyman Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

MattHyman Oct 11, 2016

Choose a reason for hiding this comment

Uh oh!

hpsin commented Oct 11, 2016

Uh oh!

MattHyman left a comment

Choose a reason for hiding this comment

Uh oh!

MattHyman commented Oct 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants