App, process, and crash dump collection APIs#193
Merged
Conversation
|
Hi @hpsin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
WilliamsJason
approved these changes
Oct 17, 2016
| BugcheckSettingsApi, | ||
| string.Format( | ||
| "autoreboot={0}&overwrite={1}&dumptype={2}&maxdumpcount={3}", | ||
| dfs.AutoReboot ? "1" : "0", dfs.Overwrite ? "1" : "0", (int)dfs.DumpType, dfs.MaxDumpCount)); |
Contributor
There was a problem hiding this comment.
There is a Utilities.BuildQueryString in the project that you can use to format this stuff (takes a dictionary of name/value pairs and formats them with the & and = signs). This seems clear enough though, so I'd be fine either way.
WilliamsJason
pushed a commit
that referenced
this pull request
Oct 18, 2016
* DeviceLab sample * This is what I showed to Dave * Committing so that I can change machines and not loose my work * Added a bunch of finishing touches * Latest polish * Added a nifty CommandSequence class * Implemented a nifty CommandSequence class and then used it for the DevicePortalCommand model * Code cleanup + style cop. Checking in for demo * Finished satisfyint StyleCop * Committing before merging changes from upstream * Integrated the new DeviceSignIn view. Fixed the timing issue in the reestablish connection retry loop. Made rename more robust. Stronger check for duplicates using the cannonical IP address * Renamed DeviceLab to SampleDeviceCollection * Added finishing touches to the code. Getting it ready for a pull request * Breaking Change: Updating async methods to follow C# async naming conventions (#188) And updating version number. * Update calls into the wrapper to use the latest async naming convention * Not tracking sync.cmd * Ended up with a stray orig file. Deleting * Change array return types to Lists for #189 (#191) * App, process, and crash dump collection APIs (#193) * Add usermode crash dump APIs * Additional fixes to DumpCollection * Add kernel, live, and app dump APIs. * StyleCop pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers #28 - Dump collections not implemented.