Fix skew transforms for string values#10365
Merged
acoates-ms merged 2 commits intomicrosoft:mainfrom Aug 3, 2022
Merged
Conversation
In microsoft#9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes microsoft#10364
rozele
added
Area: Animation
Area: View Style Props
acoates-ms
approved these changes
Aug 3, 2022
Contributor
Author
|
@acoates-ms we'll pick this into our fork and likely will skip 0.69 to go to 0.70, but do you want this to be picked back to 0.69? |
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 23, 2022
* Fix skew transforms for string values In microsoft#9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes microsoft#10364 * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
In #9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY.
Resolves #10364
What
Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call
ToRadiansbefore attempting to create the skew matrices.Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
React.Native.Playground.Win32.2022-08-03.15-06-25.mp4
Microsoft Reviewers: Open in CodeFlow