Modify transform code to allow fabric usage of transform#9798
Merged
acoates-ms merged 3 commits intomicrosoft:mainfrom Apr 18, 2022
Merged
Modify transform code to allow fabric usage of transform#9798acoates-ms merged 3 commits intomicrosoft:mainfrom
acoates-ms merged 3 commits intomicrosoft:mainfrom
Conversation
jonthysell
approved these changes
Apr 12, 2022
raghavthind2005
approved these changes
Apr 17, 2022
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Aug 3, 2022
In microsoft#9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes microsoft#10364
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Aug 3, 2022
In microsoft#9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes microsoft#10364
acoates-ms
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Fix skew transforms for string values In #9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes #10364 * Change files
rozele
pushed a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 23, 2022
…osoft#9798) * Modify transform code to allow fabric usage of transform * Change files * format
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 23, 2022
* Fix skew transforms for string values In microsoft#9798, we added functionality to update transform props directly without first converting those props into a transform matrix in JS. This change did not account for string values of skewX and skewY. Skew transforms can be specified in degrees (via string) rather than explicit float values. Ensure we call `ToRadians` before attempting to create the skew matrices. Fixes microsoft#10364 * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an if(android || ios) statement in core that makes the transform property behave differently in core than in windows. In order to use the fabric props and conversions for transform, we need windows to behave more like android/ios.
Type of Change
Deforking of bahavior. Filed #9797 and opened facebook/react-native#33579 to remove this forked file.
Microsoft Reviewers: Open in CodeFlow