Align with facebook's RN on react-native bundle --dev for BundleCommand #4277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
vmoroz
approved these changes
Mar 9, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj
Outdated
Show resolved
Hide resolved
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj
Show resolved
Hide resolved
Contributor
Author
|
Since it looks things got reworked into bundle-cpp or something to the package.json, I don't know how to pass this along properly as it's just not my area of knowledge and as the fix is already in our own project. I am just going to abandon this PR, and leave the issue #4276 open for whoever knows more about this this properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native bundle --devcurrently defaults to trueYou can see for yourself by running
npx react-native bundle --helpWith this being set to true, this is what causes yellow box warnings appearing in release builds. Or at least it did at one point. Not sure what other effects it has.
in Facebook's ReactNative android example build.
As shown here
https://github.com/facebook/react-native/blob/1fb815ed4314c1396999e64354ca0b5d4ed83663/react.gradle#L156
This PR lets you control it as well via a flag. I am adding it so that all release builds will set it appropriately. But still allow dev debug bundles to work properly.
See more info at issue #4276
Microsoft Reviewers: Open in CodeFlow