Re-enable VisitAllPages E2ETest #5699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…es just before the failing test
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5661
This change adds a couple things to make our E2E tests more reliable:
1 - The RNTester list is long, many items are scrolled out of view. We're seeing some reliability issues with scrolling into view before clicking. To workaround this, we're filtering the list down to the one test first.
2 - The $ selector tries to find elements without any guarantee they are in the UI yet. $ has some built-in retry logic but this logic is brittle and not reliable. I added some manual retry logic that runs before we try to click on anything in a test page.
Also in this change:
With these changes we should no longer see any instabilities caused by selectors not finding elements on the page.
Microsoft Reviewers: Open in CodeFlow