Fixme #5
Closed
Fixme #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* merge * fix the crash because it has problem to activate react.uwp.XamlMetaDataProvider * Update vnext/ReactUWP/Views/module.g.cpp
* merge * manually bump to vnext.80 * Change files * Change files
* Revert "Add Winui 2.2 framework package (microsoft#3622)" This reverts commit 160f555. * Change files
…3696) * Revert "Revert "Support ScrollView keyboardDismissMode" (microsoft#3692)" This reverts commit 55ef15e. * Properly support ScrollView KeyboardDismissMode * Change files * buildci * Merge update
* VM: Add support for CustomBubblingEventTypeConstants microsoft#3212 * VM: Add support for CustomDirectEventTypeConstants microsoft#3213 * Created IReactContext, which is passed in to the ViewManagerProvider delegate, to enable calling CallJSFunction and DispatchEvent from native code (partial microsoft#3208) * VMs support "JS-style objects" for event params, property types (partial microsoft#3207, microsoft#3562)
* Update to react-native@0.60.0-microsoft.24 * Change files * Change files
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.5 to 10.17.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
To install a yarn package globally, the keyword `global` has to immediately follow `yarn` as per :https://yarnpkg.com/lang/en/docs/cli/global/ `yarn add global XXXX` won't install anything globally, `yarn global add XXXX` will install the XXXX package globally.
* changes * WinUI dependency * update cppwinrt version * rollback cppwinrt version for SampleApp * WinUI 2.3 * fix build error * Fix e2e test
Bumps [beachball](https://github.com/microsoft/beachball) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/microsoft/beachball/releases) - [Changelog](https://github.com/microsoft/beachball/blob/master/azure-pipelines.release.yml) - [Commits](microsoft/beachball@beachball_v1.15.1...beachball_v1.16.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* VM: Enable custom native views that have child views, microsoft#3704 * Added CircleViewManager examples in C# and C++ * Added support for XAML enums as property values in AttributedViewManager
* Update to react-native@0.60.0-microsoft.26 * Change files * Change files
* Update to react-native@0.60.0-microsoft.28 * Change files * Change files
* Update E2ETest to use ReactApplication * Minor update * Remove generating pch.pch * Change files * Shrink pch file size for Microsfot.ReactNative * Revert "Remove generating pch.pch" This reverts commit 39286c8. * fix build * Update Timeout
Documentation update based on microsoft#2852 completion
Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack) from 7.6.1 to 7.7.0. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.6.1...@microsoft/api-extractor_v7.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@microsoft/api-documenter](https://github.com/microsoft/rushstack) from 7.6.1 to 7.7.2. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-documenter_v7.6.1...@microsoft/api-documenter_v7.7.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Re-aligned SampleAppCPP project to match the others, microsoft#3728 * Updated all projects to 2.0.190730.2
Co-authored-by: kmelmon <33470154+kmelmon@users.noreply.github.com>
…hrough to parent (microsoft#4078) (microsoft#4150) * Cherry-pick fix for 4078 * Remove duplicate keys * Remove onFocus and onBlur events Co-authored-by: Kai Guo <guokai.ok@gmail.com>
…tory (microsoft#4108) (microsoft#4161) * Fix issues with relative IntDir breaking builds * formatting * Change files * Re-order path resolution calls. NormalizePath/NormalizeDirectory are the culprits here -- they normalize to an absolute path based on current working directory. Co-authored-by: Aaron Schultz <codedclarity@gmail.com>
* Fix concurrency issue in NetworkingModule (microsoft#4179) * Add locking around access to m_requests * Change files * add locking around AbortRequest as well * fix formatting * lock needs local variable * Remove useIncrementalUpdates assert from Networking module (microsoft#4116) * Remove useIncrementalUpdates assert from Networking module * Change files * add [[maybe_unused]] Co-authored-by: Marlene Cota <marlenecota@gmail.com>
* TextBox should have a default tabIndex of 0 (microsoft#4204) * TextBox should have a default tabIndex of 0 * Change files * Set IsTabStop to false when tabIndex is negative (microsoft#4180) * Set IsTabStop to false when tabIndex is negative * Change files * remove unneeded static_cast * whoops actually did need the static_cast * clearValue and set -1 as default
…ctUWP\\Utils. Updated project references. (microsoft#4233) * Moved header files from ReactUWP\Utils to include\ReactUWP\Utils (microsoft#4230) * Moved header files from ReactUWP\Utils to include\ReactUWP\Utils. Updated project references. * updated includes to use <Utils/*> * checkin auto fix include order * Change files * reapply changes to ReactUWP.vcxproj
This backports the same change from master; it enables V8 as an optional JSI engine implementation.
…soft#4273) * Fix Support For SysTraceSection Addresses microsoft#4245, During deforking work I left a build logic typo which caused SysTraceSection to noop. When trying to reenable in deforked React Native, we end up having a compile error since stock Facebook code will pass doubles as an arg to SysTraceSection, and we will internally only accept string. This was fixed in microsof/react-native by commenting out the SysTraceSection call that passed a double. A real solution is to allow our implementation of FbSystraceSection to accept non-string args and convert to strings, as Facebook's seemingly does. - Use type traits to call std::to_string on args not convertible to string - Move functions to be private instead of public Still need a plan to validate this. * Simplify things a bit * Solely rely on is_convertible Constructable was sort of wrong before, because we're actually doing assignment, but even then we likely only want things that allow implicit conversions.
…t#4338) * Fix certs * Change files * fix * E2E needs a cert to run? Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
kmelmon
added a commit
that referenced
this pull request
Aug 14, 2020
kmelmon
added a commit
that referenced
this pull request
Aug 19, 2020
* re-enable * comment out PlatformColor test, this was the failing test in the past as well * trying again, this time commenting out PanResponder Sample, which comes just before the failing test * trying to wait for home page to load before continuing * another take on waiting for item in FlatList to be loaded first * trying new approach, enter test name in edit box to filter first * made some progress, now timing out on edit control, add polling for that control * finally! success. Try #2 * try #3, fingers crossed! * try #4 * split test into groups * bumping up timeout * try #2 with longer timeout * go back to one testspec * try #4 with longer timeout * try #5 with longer timeout. really folks I think I got it this time :) * convert all the tests to use same mechanism * Change files * remove smoke test * stability pass after removing smoke test, try #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.