-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve read_raw file extension detection #11521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would like to update our tests and try to read a file with multiple dots. For efficiency reasons, I'd like to use an existing file (e.g. |
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test_split_name_ext function?
thx @cbrnr
|
Done, ready for review. |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the preferred way to do that (i.e. should I use tmp_path from pytest or some MNE-specific object, and should I use shutil.copy() to copy and rename the EDF file)?
Yes a copyfile using tmp_path is usually what we do. Marking as changes requested so we don't forget this part!
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Done @larsoner! |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks that don't really matter (take or leave them) plus a test enhancement that I think is worthwhile
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
All done! |
|
Thanks @cbrnr ! |
* upstream/main: [MAINT, MRG] Fix failing flake tests (mne-tools#11547) Improve read_raw file extension detection (mne-tools#11521) Expand user in config paths (mne-tools#11537) Ignore pkg_resources deprecations (mne-tools#11538)
Fixes #11515.