Skip to content

Expand user in config paths #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drammock merged 5 commits into from
Mar 8, 2023
Merged

Expand user in config paths #11537

drammock merged 5 commits into from
Mar 8, 2023

Conversation

@cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Mar 7, 2023

Fixes #11533.

@cbrnr cbrnr force-pushed the config-expanduser branch from af74cae to dcad9c2 Compare March 7, 2023 13:14
@cbrnr
Copy link
Contributor Author

cbrnr commented Mar 7, 2023 •
edited
Loading

Are we still hitting the Nilearn (pkg_resources) issue after #11478? Do we need to add a new filter? I added this in #11538, let's see if it works.

drammock
drammock reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion; done through GitHub UI so it may also require removing the os.path import if that's its only usage in the file.

cbrnr and others added 2 commits March 7, 2023 20:56
@cbrnr @drammock
Update mne/datasets/utils.py
4086a69 
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@cbrnr @drammock
Update mne/datasets/utils.py
ebdec7f 
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@cbrnr
Copy link
Contributor Author

cbrnr commented Mar 8, 2023

Thanks @drammock, op is used in many other places, replacing that with pathlib would be great, but should be done in a separate PR. I think everything else looks good!

@drammock drammock merged commit fa618df into mne-tools:main Mar 8, 2023
@cbrnr cbrnr deleted the config-expanduser branch March 8, 2023 11:39
larsoner added a commit to larsoner/mne-python that referenced this pull request Mar 9, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into feature/TD-nirs_snirf
a076e23 
* upstream/main:
  [MAINT, MRG] Fix failing flake tests (mne-tools#11547)
  Improve read_raw file extension detection (mne-tools#11521)
  Expand user in config paths (mne-tools#11537)
  Ignore pkg_resources deprecations (mne-tools#11538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drammock drammock drammock left review comments

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support ~ in config

3 participants

@cbrnr @agramfort @drammock