Skip to content

Conversation

@cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Mar 7, 2023

This should fix CIs that hit a deprecation warning related to pkg_resources (follow-up to #11478).

@cbrnr cbrnr force-pushed the fix-pkg_resources-warnings branch from bd08d85 to 369d2d0 Compare March 7, 2023 15:01
@drammock
Copy link
Member

drammock commented Mar 7, 2023

nilearn/nilearn#3512 happened after the most recent nilearn release (0.10) so yeah, we still need to catch those warnings I guess, until they cut a new release. This is a new/different warning, previously it was

Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages

now it is

pkg_resources is deprecated as an API

Co-authored-by: Daniel McCloy <dan@mccloy.info>
@cbrnr
Copy link
Contributor Author

cbrnr commented Mar 7, 2023

This one's ready I think.

@drammock drammock merged commit 4397900 into mne-tools:main Mar 7, 2023
@drammock
Copy link
Member

drammock commented Mar 7, 2023

thanks @cbrnr !

@cbrnr cbrnr deleted the fix-pkg_resources-warnings branch March 8, 2023 11:40
larsoner added a commit to larsoner/mne-python that referenced this pull request Mar 9, 2023
* upstream/main:
  [MAINT, MRG] Fix failing flake tests (mne-tools#11547)
  Improve read_raw file extension detection (mne-tools#11521)
  Expand user in config paths (mne-tools#11537)
  Ignore pkg_resources deprecations (mne-tools#11538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants