[MRG] BF: String formatting in exception message #8206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mne-tools#8194 introduced changes to `mne.viz.backends._utils.VALID_3D_BACKENDS`. Now, if `viz.backends.renderer._get_3d_backend()` cannot find a valid backend, the string formatting doesn't work (`VALID_3D_BACKENDS` is a tuple, and we're trying to format the string with only a single `%s`. This commit not only fixes that, but improves formatting ever so slightly.
hoechenberger
changed the title
agramfort
approved these changes
Sep 3, 2020
larsoner
added a commit
to libertyh/mne-python
that referenced
this pull request
Sep 9, 2020
* upstream/master: (489 commits) MRG, DOC: Fix ICA docstring, add whitening (mne-tools#8227) MRG: Extract measurement date and age for NIRX files (mne-tools#7891) Nihon Kohden EEG file reader WIP (mne-tools#6017) BUG: Fix scaling for src_mri_t in coreg (mne-tools#8223) MRG: Set pyvista as default 3d backend (mne-tools#8220) MRG: Recreate our helmet graphic (mne-tools#8116) [MRG] Adding get_montage for montage to BaseRaw objects (mne-tools#7667) ENH: Allow setting tqdm backend (mne-tools#8177) [MRG, IO] Persyst reader into Raw object (mne-tools#8176) MRG, BUG: Fix errors in IO/loading/projectors (mne-tools#8210) MAINT: vectorize _read_annotations_edf (mne-tools#8214) FIX : events_from_annotation when annotations.orig_time is None and f… (mne-tools#8209) FIX: do not project to sphere; DOC - explain how to get EEGLAB-like topoplots (mne-tools#7455) [MRG, DOC] Added linear algebra of transform to doc (mne-tools#7087) FIX: Travis failure on python3.8.1 (mne-tools#8207) BF: String formatting in exception message (mne-tools#8206) BUG: Fix STC limit bug (mne-tools#8202) MRG, DOC: fix ica tutorial (mne-tools#8175) CSP component order selection (mne-tools#8151) MRG, ENH: Add on_missing to plot_events (mne-tools#8198) ...
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
mne-tools#8194 introduced changes to `mne.viz.backends._utils.VALID_3D_BACKENDS`. Now, if `viz.backends.renderer._get_3d_backend()` cannot find a valid backend, the string formatting doesn't work (`VALID_3D_BACKENDS` is a tuple, and we're trying to format the string with only a single `%s`. This commit not only fixes that, but improves formatting ever so slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
#8194 introduced changes to
mne.viz.backends._utils.VALID_3D_BACKENDS.Now, if
viz.backends.renderer._get_3d_backend()cannot find a valid backend, the string formattingdoesn't work (
VALID_3D_BACKENDSis a tuple, and we're trying to format the string with only a single%s.This commit not only fixes that, but improves formatting ever so slightly.
Additional information
@agramfort This is the reason why our scheduled study-template CI run failed last night.