MRG, MAINT: Test 3.9 #8533
Merged
MRG, MAINT: Test 3.9 #8533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Nov 17, 2020
| .. _GH-Linux: https://github.com/mne-tools/mne-python/actions?query=branch:master+event:push | ||
|
|
||
| .. |GH-macOS| image:: https://github.com/mne-tools/mne-python/workflows/macos%20/%20conda/badge.svg?branch=master | ||
| .. _GH-macOS: https://github.com/mne-tools/mne-python/actions?query=branch:master+event:push |
Member
Author
There was a problem hiding this comment.
Preview version:
I could add linux / pip etc. but since our official instructions are conda I think it makes sense to just to have the conda ones listed here.
larsoner
commented
Nov 18, 2020
| from pyvista.utilities import try_callback | ||
| from pyvista.plotting.plotting import _ALL_PLOTTERS | ||
| VTK9 = LooseVersion(vtk.VTK_VERSION) >= LooseVersion('9.0') | ||
| VTK9 = LooseVersion(getattr(vtk, 'VTK_VERSION', '9.0')) >= LooseVersion('9.0') |
Member
Author
There was a problem hiding this comment.
Member
Author
|
@GuillaumeFavelier feel free to merge if you're happy |
Contributor
|
Thanks @larsoner ! |
Closed
larsoner
added a commit
to kylemath/mne-python
that referenced
this pull request
Nov 19, 2020
* upstream/master: MRG, MAINT: Try conda-forge (mne-tools#8046) MRG, MAINT: deduplicate definition of FIFF constants (mne-tools#8537) ENH: Add realign_raw (mne-tools#8540) CI: Use 20.04 (mne-tools#8541) fix example (mne-tools#8539) MRG, VIZ, FIX: plot_sensors title and interactivity (mne-tools#8536) MRG, MAINT: Test 3.9 (mne-tools#8533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--prejob. To do this I needed to compile my own Linux VTK wheel and upload to OSF. Let's see if that works. If not I guess we can get rid of VTK there, and have a second 3.8-pre job that has VTK.Closes #8456