MRG, MAINT: deduplicate definition of FIFF constants #8537
Conversation
drammock
changed the title
|
Failures look real |
yep. ran out of steam last night. working on them now. |
drammock
force-pushed
the
dedup-FIFF-constants
branch
from
4753223 to
cc2379b
Compare
|
|
||
| def get_channel_type_constants(): | ||
| """Return all known channel types. | ||
| def get_channel_type_constants(include_defaults=False): |
There was a problem hiding this comment.
@larsoner could you have a look at how I've altered this function? As I understand it: sometimes we want the returned dict to have minimal entries (values that should always be present in info['chs'] for a given channel type, regardless of the acquisition system used). Other times, we want additional values because we use the returned dict to pre-populate an info dict for synthetic data (e.g., in create_info). Does that understanding accurately reflect all of the relevant use cases for this kind of dictionary? If so, does the approach I've taken here seem optimal?
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Otherwise LGTM. Not 100% sure on the include_defaults stuff but what you did looks reasonable
mne/io/edf/tests/test_edf.py
Outdated
|
|
||
|
|
||
| FILE = inspect.getfile(inspect.currentframe()) | ||
| KIND_DICT = get_channel_type_constants() |
There was a problem hiding this comment.
I'd rather nest this in test_edf_stim_ch_pick_up -- if we ever inadvertently break get_channel_type_constants, it will break tests during the collection rather than the running phase, which is not so nice.
drammock
changed the title
|
CIs all green, ready for review/merge. |
|
Thanks @drammock |
* upstream/master: MRG, MAINT: Try conda-forge (mne-tools#8046) MRG, MAINT: deduplicate definition of FIFF constants (mne-tools#8537) ENH: Add realign_raw (mne-tools#8540) CI: Use 20.04 (mne-tools#8541) fix example (mne-tools#8539) MRG, VIZ, FIX: plot_sensors title and interactivity (mne-tools#8536) MRG, MAINT: Test 3.9 (mne-tools#8533)
3 participants
expands the entries in
get_channel_type_constants()to include coil types and units, so they can be used increate_info.