Skip to content

Conversation

@drammock
Copy link
Member

closes #7850

  • plot_sensors now puts title as axes title instead of fig.suptitle
  • the on_pick callback now won't act unless the click was in the correct axes

@drammock drammock changed the title Fix plot sensors VIZ, FIX: plot_sensors title and interactivity Nov 17, 2020
@drammock drammock changed the title VIZ, FIX: plot_sensors title and interactivity MRG, VIZ, FIX: plot_sensors title and interactivity Nov 17, 2020
@drammock
Copy link
Member Author

Ready for review/merge. Only CI failure is the XDAWN test on py3.6 (a test which I think @larsoner is about to remove anyway).

@larsoner larsoner merged commit 5305fee into mne-tools:master Nov 18, 2020
@larsoner
Copy link
Member

Thanks @drammock

@drammock drammock mentioned this pull request Nov 18, 2020
@drammock drammock deleted the fix-plot-sensors branch November 18, 2020 17:25
larsoner added a commit to kylemath/mne-python that referenced this pull request Nov 19, 2020
* upstream/master:
  MRG, MAINT: Try conda-forge (mne-tools#8046)
  MRG, MAINT: deduplicate definition of FIFF constants (mne-tools#8537)
  ENH: Add realign_raw (mne-tools#8540)
  CI: Use 20.04 (mne-tools#8541)
  fix example (mne-tools#8539)
  MRG, VIZ, FIX: plot_sensors title and interactivity (mne-tools#8536)
  MRG, MAINT: Test 3.9 (mne-tools#8533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

viz.plot_sensors() only partially honors axes parameter

3 participants