Skip to content

Add regression test for EEGLAB data with a chanlocs struct #8647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoechenberger merged 3 commits into from
Dec 11, 2020
Merged

Add regression test for EEGLAB data with a chanlocs struct #8647

hoechenberger merged 3 commits into from
Dec 11, 2020

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Dec 11, 2020 •
edited
Loading

No description provided.

@larsoner
Copy link
Member

larsoner commented Dec 11, 2020

Usually we do this with whatever PR actually needs it

@hoechenberger
Copy link
Member Author

hoechenberger commented Dec 11, 2020

Usually we do this with whatever PR actually needs it

I guess so, but this specific release I need for testing MNE-BIDS 😅 wanted to add a test to MNE later

@hoechenberger
Copy link
Member Author

hoechenberger commented Dec 11, 2020

Then again, I can already add a test to this PR. Will update this branch.

@hoechenberger hoechenberger marked this pull request as draft December 11, 2020 13:51
@hoechenberger hoechenberger changed the title Use testing data release 0.112 Add regression test for EEGLAB data with a chanlocs struct Dec 11, 2020
@hoechenberger hoechenberger marked this pull request as ready for review December 11, 2020 14:15
@agramfort
Copy link
Member

agramfort commented Dec 11, 2020

@hoechenberger please merge when all green. thx

@hoechenberger hoechenberger merged commit 76b64ff into mne-tools:master Dec 11, 2020
@hoechenberger hoechenberger deleted the testing-data branch December 11, 2020 15:18
larsoner added a commit to agramfort/mne-python that referenced this pull request Dec 16, 2020
@larsoner
Merge remote-tracking branch 'upstream/master' into fix_rstrip_edf
84c6e81 
* upstream/master: (42 commits)
  MRG, ENH: Add DICS bias tests (mne-tools#8610)
  MRG, BUG, ENH: Add window option (mne-tools#8662)
  BUG: Fix alpha for volumes (mne-tools#8663)
  MRG, BUG: Fix bugs with envcorr (mne-tools#8658)
  MRG, ENH: Progressbar for csd_morlet (mne-tools#8608)
  Render is necessary now (mne-tools#8657)
  VIZ: Fix head size (mne-tools#8651)
  MRG, MAINT: bump sphinxcontrib-bitex version (mne-tools#8653)
  MRG, MAINT: Improve server env (mne-tools#8656)
  BUG: Mayavi center (mne-tools#8644)
  VIZ, ENH: allow show/hide annotations by label (mne-tools#8624)
  Add regression test for EEGLAB data with a chanlocs struct (mne-tools#8647)
  FIX: scalar_bar (mne-tools#8643)
  MRG: Small fix to tutorial; rename plot_events ordinate label to "Event id"; improve some SSP docstrings (mne-tools#8612)
  MRG, ENH: make plot alignment use defaults for colors (mne-tools#8553)
  BUG: Fix passing of channel type (mne-tools#8638)
  FIX: fixed loop over norm PSF/CTF options (mne-tools#8636)
  MRG, BUG: Pass kwargs (mne-tools#8630)
  DOC: Clearer error message (mne-tools#8631)
  BUG: Fix number of labels (mne-tools#8629)
  ...
larsoner added a commit to wmvanvliet/mne-python that referenced this pull request Dec 16, 2020
@larsoner
Merge remote-tracking branch 'upstream/master' into dics_rank
fc59492 
* upstream/master: (38 commits)
  MRG, ENH: Add DICS bias tests (mne-tools#8610)
  MRG, BUG, ENH: Add window option (mne-tools#8662)
  BUG: Fix alpha for volumes (mne-tools#8663)
  MRG, BUG: Fix bugs with envcorr (mne-tools#8658)
  MRG, ENH: Progressbar for csd_morlet (mne-tools#8608)
  Render is necessary now (mne-tools#8657)
  VIZ: Fix head size (mne-tools#8651)
  MRG, MAINT: bump sphinxcontrib-bitex version (mne-tools#8653)
  MRG, MAINT: Improve server env (mne-tools#8656)
  BUG: Mayavi center (mne-tools#8644)
  VIZ, ENH: allow show/hide annotations by label (mne-tools#8624)
  Add regression test for EEGLAB data with a chanlocs struct (mne-tools#8647)
  FIX: scalar_bar (mne-tools#8643)
  MRG: Small fix to tutorial; rename plot_events ordinate label to "Event id"; improve some SSP docstrings (mne-tools#8612)
  MRG, ENH: make plot alignment use defaults for colors (mne-tools#8553)
  BUG: Fix passing of channel type (mne-tools#8638)
  FIX: fixed loop over norm PSF/CTF options (mne-tools#8636)
  MRG, BUG: Pass kwargs (mne-tools#8630)
  DOC: Clearer error message (mne-tools#8631)
  BUG: Fix number of labels (mne-tools#8629)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoechenberger @larsoner @agramfort