Skip to content

Conversation

@drammock
Copy link
Member

sphinxcontrib-bibtex just released version 2.0, which includes the footnote citation code we've been using from their develop branch for quite a while.

@drammock drammock changed the title bump sphinxcontrib-bitex version MAINT: bump sphinxcontrib-bitex version Dec 12, 2020
@larsoner
Copy link
Member

Circle failed

@drammock drammock changed the title MAINT: bump sphinxcontrib-bitex version MRG, MAINT: bump sphinxcontrib-bitex version Dec 12, 2020
@drammock
Copy link
Member Author

fixed. ready for review/merge. Here's the general bib, looks fine:

https://24073-1301584-gh.circle-artifacts.com/0/dev/bibliography.html

@drammock drammock marked this pull request as draft December 12, 2020 16:29
@drammock
Copy link
Member Author

scratch that. the footcites aren't working. sigh.

@drammock
Copy link
Member Author

drammock commented Dec 12, 2020

actually, this does appear to be working properly, at least here:
https://24073-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_60_maxwell_filtering_sss.html#references

previously I just happened to randomly check this page:
https://24073-1301584-gh.circle-artifacts.com/0/dev/auto_examples/preprocessing/plot_eeg_csd.html#references

...and saw no references, but that's because the footcite formatting is messed up on that page. I'll push a fix to that one page, and then this should be ready to go.

@drammock drammock marked this pull request as ready for review December 12, 2020 17:52
@larsoner larsoner merged commit e40e592 into mne-tools:master Dec 14, 2020
@larsoner
Copy link
Member

Thanks @drammock

larsoner added a commit to agramfort/mne-python that referenced this pull request Dec 16, 2020
* upstream/master: (42 commits)
  MRG, ENH: Add DICS bias tests (mne-tools#8610)
  MRG, BUG, ENH: Add window option (mne-tools#8662)
  BUG: Fix alpha for volumes (mne-tools#8663)
  MRG, BUG: Fix bugs with envcorr (mne-tools#8658)
  MRG, ENH: Progressbar for csd_morlet (mne-tools#8608)
  Render is necessary now (mne-tools#8657)
  VIZ: Fix head size (mne-tools#8651)
  MRG, MAINT: bump sphinxcontrib-bitex version (mne-tools#8653)
  MRG, MAINT: Improve server env (mne-tools#8656)
  BUG: Mayavi center (mne-tools#8644)
  VIZ, ENH: allow show/hide annotations by label (mne-tools#8624)
  Add regression test for EEGLAB data with a chanlocs struct (mne-tools#8647)
  FIX: scalar_bar (mne-tools#8643)
  MRG: Small fix to tutorial; rename plot_events ordinate label to "Event id"; improve some SSP docstrings (mne-tools#8612)
  MRG, ENH: make plot alignment use defaults for colors (mne-tools#8553)
  BUG: Fix passing of channel type (mne-tools#8638)
  FIX: fixed loop over norm PSF/CTF options (mne-tools#8636)
  MRG, BUG: Pass kwargs (mne-tools#8630)
  DOC: Clearer error message (mne-tools#8631)
  BUG: Fix number of labels (mne-tools#8629)
  ...
larsoner added a commit to wmvanvliet/mne-python that referenced this pull request Dec 16, 2020
* upstream/master: (38 commits)
  MRG, ENH: Add DICS bias tests (mne-tools#8610)
  MRG, BUG, ENH: Add window option (mne-tools#8662)
  BUG: Fix alpha for volumes (mne-tools#8663)
  MRG, BUG: Fix bugs with envcorr (mne-tools#8658)
  MRG, ENH: Progressbar for csd_morlet (mne-tools#8608)
  Render is necessary now (mne-tools#8657)
  VIZ: Fix head size (mne-tools#8651)
  MRG, MAINT: bump sphinxcontrib-bitex version (mne-tools#8653)
  MRG, MAINT: Improve server env (mne-tools#8656)
  BUG: Mayavi center (mne-tools#8644)
  VIZ, ENH: allow show/hide annotations by label (mne-tools#8624)
  Add regression test for EEGLAB data with a chanlocs struct (mne-tools#8647)
  FIX: scalar_bar (mne-tools#8643)
  MRG: Small fix to tutorial; rename plot_events ordinate label to "Event id"; improve some SSP docstrings (mne-tools#8612)
  MRG, ENH: make plot alignment use defaults for colors (mne-tools#8553)
  BUG: Fix passing of channel type (mne-tools#8638)
  FIX: fixed loop over norm PSF/CTF options (mne-tools#8636)
  MRG, BUG: Pass kwargs (mne-tools#8630)
  DOC: Clearer error message (mne-tools#8631)
  BUG: Fix number of labels (mne-tools#8629)
  ...
@drammock drammock deleted the bump-version branch February 9, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants