Add querystring to MozLog "request.summary"
#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 97.97% 98.01% +0.03%
==========================================
Files 22 22
Lines 692 705 +13
Branches 92 96 +4
==========================================
+ Hits 678 691 +13
Misses 8 8
Partials 6 6 ☔ View full report in Codecov by Sentry. |
alexcottner
previously approved these changes
Feb 21, 2024
Contributor
|
I am assuming we won't have anything sensitive in the query string. |
Contributor
Author
Now that you say it, maybe it should be behind a setting and opt-in, just to be extra safe. |
leplatrem
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Feb 22, 2024
leplatrem
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Feb 22, 2024
4 tasks
Closed
leplatrem
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Mar 6, 2024
leplatrem
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Mar 6, 2024
leplatrem
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Mar 7, 2024
* Remove redundant code * Set APP_DIR explicitly Without this, the APP_DIR is `/app` which makes tests fail. * python-dockerflow does not log querystrings (see mozilla-services/python-dockerflow#97) * Include dockerflow submodules in overrides * Include fastapi subdeps * Reorder imports * Register checks in lifespan (#878) * Register checks in lifespan * Add bugzilla checks * Ignore lifespan type * Add type to lifespan * Prepare for new features of python-dockerflow * Prepare for dockerflow-2024.3.0 * Revert "python-dockerflow does not log querystrings (see mozilla-services/python-dockerflow#97)" This reverts commit fbfe9e3. --------- Co-authored-by: grahamalama <gbeckley@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.