Leverage dockerflow 2024.3.0 #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
leverage-dockerflow-2024.2.0
branch
from
84e49ec to
ddb0cbc
Compare
Without this, the APP_DIR is `/app` which makes tests fail.
leplatrem
force-pushed
the
leverage-dockerflow-2024.2.0
branch
from
68d4f3d to
621c816
Compare
Contributor
Author
|
@grahamalama do you want to cherry-pick and add your commit 643bee9 on top of this? |
* Register checks in lifespan * Add bugzilla checks * Ignore lifespan type
leplatrem
force-pushed
the
leverage-dockerflow-2024.2.0
branch
from
8aa07c5 to
df4d3ce
Compare
leplatrem
force-pushed
the
leverage-dockerflow-2024.2.0
branch
from
df4d3ce to
191b5d8
Compare
alexcottner
reviewed
Mar 6, 2024
| return [] | ||
|
|
||
| def check_jira_pandoc_install(self): | ||
| if markdown_to_jira("- Test") != "* Test": |
Contributor
There was a problem hiding this comment.
I would have assumed we'd get an exception rather than an invalid string being returned.
Contributor
Author
There was a problem hiding this comment.
Hmm, you made me doubt... if an exception is raised then the endpoint returns 500 as expected
alexcottner
approved these changes
Mar 6, 2024
Contributor
alexcottner
left a comment
alexcottner
left a comment
There was a problem hiding this comment.
Looks like we're doing better things with less code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"request.summary"mozilla-services/python-dockerflow#97