Register checks in lifespan #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Feb 23, 2024
|
|
||
| # https://github.com/tiangolo/fastapi/discussions/9241 | ||
| @asynccontextmanager | ||
| async def lifespan(app: FastAPI): # type: ignore |
Contributor
There was a problem hiding this comment.
Suggested change
| async def lifespan(app: FastAPI): # type: ignore | |
| async def lifespan(app: FastAPI) -> AsyncIterator[None]: |
leplatrem
approved these changes
Feb 23, 2024
Contributor
leplatrem
left a comment
leplatrem
left a comment
There was a problem hiding this comment.
I find it clean 💯
Thanks a lot!
There are a few details (eg. repeated with TestClient(app)) that I'll try to address in the target branch...
leplatrem
added a commit
that referenced
this pull request
Mar 7, 2024
* Remove redundant code * Set APP_DIR explicitly Without this, the APP_DIR is `/app` which makes tests fail. * python-dockerflow does not log querystrings (see mozilla-services/python-dockerflow#97) * Include dockerflow submodules in overrides * Include fastapi subdeps * Reorder imports * Register checks in lifespan (#878) * Register checks in lifespan * Add bugzilla checks * Ignore lifespan type * Add type to lifespan * Prepare for new features of python-dockerflow * Prepare for dockerflow-2024.3.0 * Revert "python-dockerflow does not log querystrings (see mozilla-services/python-dockerflow#97)" This reverts commit fbfe9e3. --------- Co-authored-by: grahamalama <gbeckley@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some somewhat raw notes:
Using a client context manager for lifespan events: https://fastapi.tiangolo.com/advanced/testing-events/
Though the startup and shutdown events are deprecated, this seemed to work here
Also, I thought I'd need to do something like this, but I didn't 🤷🏻