[stable-2.0] Make response member in OkHttpMethodBase nullable #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class uses non-null lateinit variable that is not initialized. The member should be of nullable type. Fixes nextcloud/android#5073 Fixes nextcloud/android#5102 Fixes nextcloud/android#5100 Fixes nextcloud/android#5142 Fixes nextcloud/android#5156 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
backportbot-nextcloud
bot
requested review from
AndyScherzinger,
ezaquarii and
tobiasKaminsky
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1384 |
AndyScherzinger
approved these changes
Jan 14, 2020
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-2.0)
|
Codecov Report
@@ Coverage Diff @@
## stable-2.0 #381 +/- ##
==============================================
- Coverage 34.29% 34.29% -0.01%
==============================================
Files 133 133
Lines 5724 5727 +3
Branches 751 751
==============================================
+ Hits 1963 1964 +1
- Misses 3487 3488 +1
- Partials 274 275 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #380