Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12139.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

329

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #5102 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

@@             Coverage Diff              @@
##             master    #5102      +/-   ##
============================================
- Coverage     17.79%   17.76%   -0.04%     
  Complexity        3        3              
============================================
  Files           389      389              
  Lines         32904    32898       -6     
  Branches       4628     4627       -1     
============================================
- Hits           5855     5844      -11     
- Misses        26095    26097       +2     
- Partials        954      957       +3
Impacted Files Coverage Δ Complexity Δ
...xtcloud/client/account/UserAccountManagerImpl.java 58.99% <ø> (+0.42%) 0 <0> (ø) ⬇️
...m/nextcloud/client/account/UserAccountManager.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../android/authentication/AuthenticatorActivity.java 1.81% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/ui/fragment/ExtendedListFragment.java 52.45% <0%> (+0.63%) 0 <0> (ø) ⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java 45.38% <100%> (-0.09%) 0 <0> (ø)
src/main/java/com/owncloud/android/MainApp.java 49.25% <100%> (ø) 0 <0> (ø) ⬇️
...d/android/operations/GetCapabilitiesOperation.java 75% <0%> (-12.5%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.41% <0%> (-1.56%) 0% <0%> (ø)
...com/owncloud/android/ui/activity/FileActivity.java 25.66% <0%> (-0.76%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.12% <0%> (-0.32%) 0% <0%> (ø)
... and 2 more

@AndyScherzinger AndyScherzinger merged commit f690417 into master Jan 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the removeNC12 branch January 6, 2020 18:24
tobiasKaminsky added a commit that referenced this pull request Jan 7, 2020
f690417 Merge pull request #5102 from nextcloud/removeNC12
051423c remove support for NC12
d7d1c47 Merge pull request #5031 from nextcloud/ezaquarii/fix-npe-crash-when-storage-manager-is-not-set
9b79b85 Merge pull request #5065 from nextcloud/ezaquarii/fix-crash-when-making-new-ods-file
32ebe69 Merge pull request #5066 from nextcloud/ezaquarii/fix-shared-by-null-glitch
6e07d18 Merge pull request #5035 from nextcloud/enh/clickableMarkdownLinks
5fce6ca Removed unneeded try/catch
a680697 Removed unneeded try/catch
154b9af adjusted to master
a15f724 Make hyperlinks clickable in markdown previews
5f70ea6 Make hyperlinks clickable in markdown previews
cd0f834 [tx-robot] updated from transifex
22ab16e [tx-robot] updated from transifex
80d7d26 [tx-robot] updated from transifex
6d76582 [tx-robot] updated from transifex
167b250 Merge pull request #5085 from nextcloud/dependabot/gradle/junit-junit-4.13
7b6e1b7 [tx-robot] updated from transifex
1c12ca0 Bump junit from 4.12 to 4.13
71f919f [tx-robot] updated from transifex
fc00d7d Merge pull request #5077 from nextcloud/dependabot/gradle/daggerVersion-2.25.4
9a3bf3a Bump daggerVersion from 2.25.3 to 2.25.4
0c3b8fc [tx-robot] updated from transifex
ef84976 Fix "Shared by null" glitch in file details view
3cf3e3b Fix crash when adding new ODS file
2047079 Merge pull request #5060 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.3.0
2882236 Bump detekt-gradle-plugin from 1.2.2 to 1.3.0
3687301 [tx-robot] updated from transifex
f53d637 [tx-robot] updated from transifex
24921f6 [tx-robot] updated from transifex
c30c6c7 daily dev 20191221
ezaquarii added a commit to nextcloud/android-library that referenced this pull request Jan 11, 2020
The class uses non-null lateinit variable that
is not initialized. The member should be of
nullable type.

Fixes nextcloud/android#5073
Fixes nextcloud/android#5102
Fixes nextcloud/android#5100
Fixes nextcloud/android#5142
Fixes nextcloud/android#5156

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii added a commit to nextcloud/android-library that referenced this pull request Jan 11, 2020
The class uses non-null lateinit variable that
is not initialized. The member should be of
nullable type.

Fixes nextcloud/android#5073
Fixes nextcloud/android#5102
Fixes nextcloud/android#5100
Fixes nextcloud/android#5142
Fixes nextcloud/android#5156

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii added a commit to nextcloud/android-library that referenced this pull request Jan 11, 2020
The class uses non-null lateinit variable that
is not initialized. The member should be of
nullable type.

Fixes nextcloud/android#5073
Fixes nextcloud/android#5102
Fixes nextcloud/android#5100
Fixes nextcloud/android#5142
Fixes nextcloud/android#5156

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii added a commit to nextcloud/android-library that referenced this pull request Jan 14, 2020
The class uses non-null lateinit variable that
is not initialized. The member should be of
nullable type.

Fixes nextcloud/android#5073
Fixes nextcloud/android#5102
Fixes nextcloud/android#5100
Fixes nextcloud/android#5142
Fixes nextcloud/android#5156

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
backportbot-nextcloud bot pushed a commit to nextcloud/android-library that referenced this pull request Jan 14, 2020
The class uses non-null lateinit variable that
is not initialized. The member should be of
nullable type.

Fixes nextcloud/android#5073
Fixes nextcloud/android#5102
Fixes nextcloud/android#5100
Fixes nextcloud/android#5142
Fixes nextcloud/android#5156

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants