-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix crash when adding new ODS file #5065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when adding new ODS file #5065
Conversation
Crash was caused by async task callback firing when Fragment is not attached to activity. Check if fragment is attached before invoking callback logic. Fixes: #5020 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12099.apk |
Codacy327Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5065 +/- ##
============================================
+ Coverage 17.67% 17.72% +0.04%
Complexity 3 3
============================================
Files 389 389
Lines 32893 32893
Branches 4627 4627
============================================
+ Hits 5815 5830 +15
+ Misses 26128 26111 -17
- Partials 950 952 +2
|
f690417 Merge pull request #5102 from nextcloud/removeNC12 051423c remove support for NC12 d7d1c47 Merge pull request #5031 from nextcloud/ezaquarii/fix-npe-crash-when-storage-manager-is-not-set 9b79b85 Merge pull request #5065 from nextcloud/ezaquarii/fix-crash-when-making-new-ods-file 32ebe69 Merge pull request #5066 from nextcloud/ezaquarii/fix-shared-by-null-glitch 6e07d18 Merge pull request #5035 from nextcloud/enh/clickableMarkdownLinks 5fce6ca Removed unneeded try/catch a680697 Removed unneeded try/catch 154b9af adjusted to master a15f724 Make hyperlinks clickable in markdown previews 5f70ea6 Make hyperlinks clickable in markdown previews cd0f834 [tx-robot] updated from transifex 22ab16e [tx-robot] updated from transifex 80d7d26 [tx-robot] updated from transifex 6d76582 [tx-robot] updated from transifex 167b250 Merge pull request #5085 from nextcloud/dependabot/gradle/junit-junit-4.13 7b6e1b7 [tx-robot] updated from transifex 1c12ca0 Bump junit from 4.12 to 4.13 71f919f [tx-robot] updated from transifex fc00d7d Merge pull request #5077 from nextcloud/dependabot/gradle/daggerVersion-2.25.4 9a3bf3a Bump daggerVersion from 2.25.3 to 2.25.4 0c3b8fc [tx-robot] updated from transifex ef84976 Fix "Shared by null" glitch in file details view 3cf3e3b Fix crash when adding new ODS file 2047079 Merge pull request #5060 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.3.0 2882236 Bump detekt-gradle-plugin from 1.2.2 to 1.3.0 3687301 [tx-robot] updated from transifex f53d637 [tx-robot] updated from transifex 24921f6 [tx-robot] updated from transifex c30c6c7 daily dev 20191221
|
Still having this problem. ************ CAUSE OF ERROR ************ java.lang.IllegalStateException: calling this from your main thread can lead to deadlock ************ APP INFORMATION ************ ************ DEVICE INFORMATION ************ ************ FIRMWARE ************ |
|
@dysonsphere-startmail I created a new issue #6212 since the error you report leads to the same result (crash) but is a different issue. |

Crash was caused by async task callback firing when
Fragment is not attached to activity.
Check if fragment is attached before invoking
callback logic.
Fixes: #5020
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com