Fix NPE crash on startup when storage manager is not set

[ezaquarii]

Fixes #4941

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[codecov]

Codecov Report

Merging #5031 into master will increase coverage by 0.03%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master    #5031      +/-   ##
============================================
+ Coverage     17.58%   17.61%   +0.03%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32679    32681       +2     
  Branches       4594     4594              
============================================
+ Hits           5745     5757      +12     
+ Misses        26008    25993      -15     
- Partials        926      931       +5

Impacted Files	Coverage Δ	Complexity Δ
...cloud/android/ui/activity/FileDisplayActivity.java	20.19% <66.66%> (-0.02%)	0 <0> (ø)
...com/owncloud/android/ui/activity/BaseActivity.java	36.66% <80%> (+6.32%)	0 <0> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	80.95% <0%> (-1.2%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	33.75% <0%> (-0.55%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	29.86% <0%> (-0.19%)	0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java	26.31% <0%> (ø)	0% <0%> (ø)	⬇️
...xtcloud/client/account/UserAccountManagerImpl.java	58.27% <0%> (+7.91%)	0% <0%> (ø)	⬇️

[ezaquarii]

@tobiasKaminsky When creating new account, I see that we jump through 5 activities.

FileDisplayActivity 1 -> AuthenticatorActivity -> FirstRunActivity -> FileDisplayActivity 2 -> FileDisplayActivity 3

FileDisplayActivity 2 is for some reason resumed and paused few times before FileDisplayActivity 3 comes to life.

The whole flow is pretty complicated and I believe we could simplify it just a bit by removing the authenticator callback in FileDisplayActivity 1, as it dies immediately after launching AuthenticatorActivity.

[ezaquarii]

I tried to run it without it. I managed to create the account properly, but it landed in empty file list activity as a result, requiring extra pull-to-refresh.

[tobiasKaminsky]

We have somewhere a delay of 500ms to do a very first loading of folder content, maybe it just takes a bit too long for you.

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12049.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

328

Lint

Type	master	PR
Warnings	73	73
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

[tobiasKaminsky]

The whole flow is pretty complicated

it is indeed.
As old login flow is deprecated since NC12, I will remove this for 3.11.
This then should simplify it a lot and I will take your idea into account.