Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

Bumps daggerVersion from 2.25.3 to 2.25.4.
Updates dagger from 2.25.3 to 2.25.4

Release notes

Sourced from dagger's releases.

Dagger 2.25.4

What's new

Bug fixes

  • #1645: Fix memory leak in RequestKinds cache. (2902519e)
Commits
  • a1eb5b0 2.25.4 release
  • 0d2505a Add a flag -Adagger.experimentalDaggerErrorMessages for controlling the new e...
  • 2902519 Remove static RequestKinds cache and improve build performance.
  • 545f851 Refactor RequestKinds.extractKeyType(RequestKind, TypeMirror) to RequestKinds...
  • 405d8f9 Make ModuleProxises an injectable class.
  • 709098c Add version tracking file to deployed Dagger artifacts.
  • See full diff in compare view

Updates dagger-android from 2.25.3 to 2.25.4

Release notes

Sourced from dagger-android's releases.

Dagger 2.25.4

What's new

Bug fixes

  • #1645: Fix memory leak in RequestKinds cache. (2902519e)
Commits
  • a1eb5b0 2.25.4 release
  • 0d2505a Add a flag -Adagger.experimentalDaggerErrorMessages for controlling the new e...
  • 2902519 Remove static RequestKinds cache and improve build performance.
  • 545f851 Refactor RequestKinds.extractKeyType(RequestKind, TypeMirror) to RequestKinds...
  • 405d8f9 Make ModuleProxises an injectable class.
  • 709098c Add version tracking file to deployed Dagger artifacts.
  • See full diff in compare view

Updates dagger-android-support from 2.25.3 to 2.25.4

Release notes

Sourced from dagger-android-support's releases.

Dagger 2.25.4

What's new

Bug fixes

  • #1645: Fix memory leak in RequestKinds cache. (2902519e)
Commits
  • a1eb5b0 2.25.4 release
  • 0d2505a Add a flag -Adagger.experimentalDaggerErrorMessages for controlling the new e...
  • 2902519 Remove static RequestKinds cache and improve build performance.
  • 545f851 Refactor RequestKinds.extractKeyType(RequestKind, TypeMirror) to RequestKinds...
  • 405d8f9 Make ModuleProxises an injectable class.
  • 709098c Add version tracking file to deployed Dagger artifacts.
  • See full diff in compare view

Updates dagger-compiler from 2.25.3 to 2.25.4

Release notes

Sourced from dagger-compiler's releases.

Dagger 2.25.4

What's new

Bug fixes

  • #1645: Fix memory leak in RequestKinds cache. (2902519e)
Commits
  • a1eb5b0 2.25.4 release
  • 0d2505a Add a flag -Adagger.experimentalDaggerErrorMessages for controlling the new e...
  • 2902519 Remove static RequestKinds cache and improve build performance.
  • 545f851 Refactor RequestKinds.extractKeyType(RequestKind, TypeMirror) to RequestKinds...
  • 405d8f9 Make ModuleProxises an injectable class.
  • 709098c Add version tracking file to deployed Dagger artifacts.
  • See full diff in compare view

Updates dagger-android-processor from 2.25.3 to 2.25.4

Release notes

Sourced from dagger-android-processor's releases.

Dagger 2.25.4

What's new

Bug fixes

  • #1645: Fix memory leak in RequestKinds cache. (2902519e)
Commits
  • a1eb5b0 2.25.4 release
  • 0d2505a Add a flag -Adagger.experimentalDaggerErrorMessages for controlling the new e...
  • 2902519 Remove static RequestKinds cache and improve build performance.
  • 545f851 Refactor RequestKinds.extractKeyType(RequestKind, TypeMirror) to RequestKinds...
  • 405d8f9 Make ModuleProxises an injectable class.
  • 709098c Add version tracking file to deployed Dagger artifacts.
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps `daggerVersion` from 2.25.3 to 2.25.4.

Updates `dagger` from 2.25.3 to 2.25.4
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.25.3...dagger-2.25.4)

Updates `dagger-android` from 2.25.3 to 2.25.4
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.25.3...dagger-2.25.4)

Updates `dagger-android-support` from 2.25.3 to 2.25.4
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.25.3...dagger-2.25.4)

Updates `dagger-compiler` from 2.25.3 to 2.25.4
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.25.3...dagger-2.25.4)

Updates `dagger-android-processor` from 2.25.3 to 2.25.4
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.25.3...dagger-2.25.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Dec 30, 2019
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12110.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

327

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #5077 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5077      +/-   ##
============================================
+ Coverage     17.67%   17.68%   +<.01%     
  Complexity        3        3              
============================================
  Files           389      389              
  Lines         32893    32893              
  Branches       4627     4627              
============================================
+ Hits           5813     5816       +3     
+ Misses        26129    26128       -1     
+ Partials        951      949       -2
Impacted Files Coverage Δ Complexity Δ
.../third_parties/daveKoeller/AlphanumComparator.java 79.76% <0%> (-2.39%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.02% <0%> (-0.39%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.14% <0%> (+0.07%) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 26.81% <0%> (+1.25%) 0% <0%> (ø) ⬇️

@dependabot-preview dependabot-preview bot merged commit fc00d7d into master Dec 30, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/gradle/daggerVersion-2.25.4 branch December 30, 2019 20:11
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 30, 2019
tobiasKaminsky added a commit that referenced this pull request Jan 7, 2020
f690417 Merge pull request #5102 from nextcloud/removeNC12
051423c remove support for NC12
d7d1c47 Merge pull request #5031 from nextcloud/ezaquarii/fix-npe-crash-when-storage-manager-is-not-set
9b79b85 Merge pull request #5065 from nextcloud/ezaquarii/fix-crash-when-making-new-ods-file
32ebe69 Merge pull request #5066 from nextcloud/ezaquarii/fix-shared-by-null-glitch
6e07d18 Merge pull request #5035 from nextcloud/enh/clickableMarkdownLinks
5fce6ca Removed unneeded try/catch
a680697 Removed unneeded try/catch
154b9af adjusted to master
a15f724 Make hyperlinks clickable in markdown previews
5f70ea6 Make hyperlinks clickable in markdown previews
cd0f834 [tx-robot] updated from transifex
22ab16e [tx-robot] updated from transifex
80d7d26 [tx-robot] updated from transifex
6d76582 [tx-robot] updated from transifex
167b250 Merge pull request #5085 from nextcloud/dependabot/gradle/junit-junit-4.13
7b6e1b7 [tx-robot] updated from transifex
1c12ca0 Bump junit from 4.12 to 4.13
71f919f [tx-robot] updated from transifex
fc00d7d Merge pull request #5077 from nextcloud/dependabot/gradle/daggerVersion-2.25.4
9a3bf3a Bump daggerVersion from 2.25.3 to 2.25.4
0c3b8fc [tx-robot] updated from transifex
ef84976 Fix "Shared by null" glitch in file details view
3cf3e3b Fix crash when adding new ODS file
2047079 Merge pull request #5060 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.3.0
2882236 Bump detekt-gradle-plugin from 1.2.2 to 1.3.0
3687301 [tx-robot] updated from transifex
f53d637 [tx-robot] updated from transifex
24921f6 [tx-robot] updated from transifex
c30c6c7 daily dev 20191221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants