Fix "Shared by null" glitch in file details view #5066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When file is uploaded it has ownerId == null. We shall interpret this condition file being owned by the current user. Fixes #5005 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
ezaquarii
force-pushed
the
ezaquarii/fix-shared-by-null-glitch
branch
from
baac657 to
ef84976
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12101.apk |
Collaborator
Codacy327Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5066 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01%
Complexity 3 3
============================================
Files 389 389
Lines 32893 32894 +1
Branches 4627 4628 +1
============================================
- Hits 5815 5813 -2
- Misses 26128 26131 +3
Partials 950 950
|
tobiasKaminsky
approved these changes
Jan 6, 2020
delete-merged-branch
bot
deleted the
ezaquarii/fix-shared-by-null-glitch
branch
tobiasKaminsky
added a commit
that referenced
this pull request
Jan 7, 2020
f690417 Merge pull request #5102 from nextcloud/removeNC12 051423c remove support for NC12 d7d1c47 Merge pull request #5031 from nextcloud/ezaquarii/fix-npe-crash-when-storage-manager-is-not-set 9b79b85 Merge pull request #5065 from nextcloud/ezaquarii/fix-crash-when-making-new-ods-file 32ebe69 Merge pull request #5066 from nextcloud/ezaquarii/fix-shared-by-null-glitch 6e07d18 Merge pull request #5035 from nextcloud/enh/clickableMarkdownLinks 5fce6ca Removed unneeded try/catch a680697 Removed unneeded try/catch 154b9af adjusted to master a15f724 Make hyperlinks clickable in markdown previews 5f70ea6 Make hyperlinks clickable in markdown previews cd0f834 [tx-robot] updated from transifex 22ab16e [tx-robot] updated from transifex 80d7d26 [tx-robot] updated from transifex 6d76582 [tx-robot] updated from transifex 167b250 Merge pull request #5085 from nextcloud/dependabot/gradle/junit-junit-4.13 7b6e1b7 [tx-robot] updated from transifex 1c12ca0 Bump junit from 4.12 to 4.13 71f919f [tx-robot] updated from transifex fc00d7d Merge pull request #5077 from nextcloud/dependabot/gradle/daggerVersion-2.25.4 9a3bf3a Bump daggerVersion from 2.25.3 to 2.25.4 0c3b8fc [tx-robot] updated from transifex ef84976 Fix "Shared by null" glitch in file details view 3cf3e3b Fix crash when adding new ODS file 2047079 Merge pull request #5060 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.3.0 2882236 Bump detekt-gradle-plugin from 1.2.2 to 1.3.0 3687301 [tx-robot] updated from transifex f53d637 [tx-robot] updated from transifex 24921f6 [tx-robot] updated from transifex c30c6c7 daily dev 20191221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When file is uploaded it has ownerId == null.
We shall interpret this condition file being
owned by the current user.
Signed-off-by: Chris Narkiewicz hello@ezaquarii.com