rich workspaces #5130
Merged
rich workspaces #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-3.10 |
Member
Author
|
|
Member
Author
juliusknorr
approved these changes
Jan 9, 2020
Member
|
Tested and works, also fixes the file creation with OO |
- show button to create folder info - bug fixes Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
createRichWorkspace
branch
from
f8dadc5 to
0e5a772
Compare
| url, | ||
| requireContext()); | ||
| } else { | ||
| DisplayUtils.showSnackMessage(getView(), "Error"); |
Member
There was a problem hiding this comment.
please use a strings.xml `@StringRes´ string resource that can be translated :)
| --> | ||
| <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | ||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" |
Member
There was a problem hiding this comment.
why did you drop the scrollview?
Member
There was a problem hiding this comment.
Ans will this work for non rich-text previews (if they still exist?)?
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
approved these changes
Jan 9, 2020
Member
Author
|
Lint: |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Codecov Report
@@ Coverage Diff @@
## master #5130 +/- ##
===========================================
+ Coverage 17.62% 17.7% +0.08%
Complexity 3 3
===========================================
Files 392 392
Lines 33116 33134 +18
Branches 4651 4655 +4
===========================================
+ Hits 5836 5867 +31
+ Misses 26329 26310 -19
- Partials 951 957 +6
|
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12223.apk |
Collaborator
Codacy340Lint
SpotBugs (new)
SpotBugs (master)
|
|
backport to stable-3.10 in #5152 |
tobiasKaminsky
added a commit
that referenced
this pull request
Jan 12, 2020
ec515d0 [tx-robot] updated from transifex 422a61d Merge pull request #5136 from nextcloud/systemDefault 6e96e99 Merge pull request #5130 from nextcloud/createRichWorkspace b7a7772 Merge pull request #5122 from nextcloud/firstRun 603825e update screenshot c4d5e41 Merge pull request #5143 from nextcloud/background c6d89ed only allow rich workspace creation on >= Lollipop 87dae2e show first run again 9125285 manually increasing lint due to "autoMirrored" warning 4c10cf5 launcher: correct folder position according to AS 51fdf94 [tx-robot] updated from transifex e0b77f9 daily dev 20200110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me