Skip to content

make "follow system" default for dark theme #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 2 commits into from
Jan 10, 2020
Merged

make "follow system" default for dark theme #5136

tobiasKaminsky merged 2 commits into from
Jan 10, 2020

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jan 9, 2020

Fix #5123

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
make "follow system" default for dark theme
15ac231 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.11.0 milestone Jan 9, 2020
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 9, 2020

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12195-IT

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 9, 2020

Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12199-Screenshot

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 10, 2020

Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12207-Screenshot

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 10, 2020

Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12212-Screenshot

@tobiasKaminsky
update screenshot
603825e 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 10, 2020

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12219.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 10, 2020

Codacy

340

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #5136 into master will increase coverage by 0.06%.
The diff coverage is 40%.

@@             Coverage Diff              @@
##             master    #5136      +/-   ##
============================================
+ Coverage     17.62%   17.69%   +0.06%     
  Complexity        3        3              
============================================
  Files           392      392              
  Lines         33116    33120       +4     
  Branches       4651     4653       +2     
============================================
+ Hits           5837     5860      +23     
+ Misses        26320    26303      -17     
+ Partials        959      957       -2
Impacted Files Coverage Δ Complexity Δ
...xtcloud/client/preferences/AppPreferencesImpl.java 53.51% <33.33%> (ø) 0 <0> (ø) ⬇️
...owncloud/android/ui/activity/SettingsActivity.java 39.57% <50%> (ø) 0 <0> (ø) ⬇️
...xtcloud/client/account/UserAccountManagerImpl.java 63.3% <0%> (-1.44%) 0% <0%> (ø)
src/main/java/com/owncloud/android/MainApp.java 48.95% <0%> (-0.3%) 0% <0%> (ø)
...ud/android/ui/adapter/NotificationListAdapter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (ø) 0% <0%> (ø) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 25.6% <0%> (+0.4%) 0% <0%> (ø) ⬇️
.../nextcloud/client/onboarding/FirstRunActivity.java 38.04% <0%> (+0.68%) 0% <0%> (ø) ⬇️
...com/owncloud/android/ui/activity/BaseActivity.java 37.63% <0%> (+0.96%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (+1.19%) 0% <0%> (ø) ⬇️
... and 2 more

@tobiasKaminsky tobiasKaminsky merged commit 422a61d into master Jan 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the systemDefault branch January 10, 2020 19:16
tobiasKaminsky added a commit that referenced this pull request Jan 12, 2020
@tobiasKaminsky
daily dev 20200112
09d98e1 
ec515d0 [tx-robot] updated from transifex
422a61d Merge pull request #5136 from nextcloud/systemDefault
6e96e99 Merge pull request #5130 from nextcloud/createRichWorkspace
b7a7772 Merge pull request #5122 from nextcloud/firstRun
603825e update screenshot
c4d5e41 Merge pull request #5143 from nextcloud/background
c6d89ed only allow rich workspace creation on >= Lollipop
87dae2e show first run again
9125285 manually increasing lint due to "autoMirrored" warning
4c10cf5 launcher: correct folder position according to AS
51fdf94 [tx-robot] updated from transifex
e0b77f9 daily dev 20200110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.11.0

Development

Successfully merging this pull request may close these issues.

[3.10 RC1] Standarddesign should be: use System defaults

4 participants

@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger