Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

We had two times ic_launcher_foreground.xml
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.10

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this then also be v24 instead of the general folder?

@tobiasKaminsky
Copy link
Member Author

Shouldn't this then also be v24 instead of the general folder?

That is what AS is doing… I have no idea why…

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12213.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

341

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #5143 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5143      +/-   ##
============================================
- Coverage     17.71%   17.64%   -0.08%     
  Complexity        3        3              
============================================
  Files           392      392              
  Lines         33116    33116              
  Branches       4651     4651              
============================================
- Hits           5868     5843      -25     
- Misses        26292    26321      +29     
+ Partials        956      952       -4
Impacted Files Coverage Δ Complexity Δ
...com/nextcloud/client/logger/LegacyLoggerAdapter.kt 66.66% <0%> (-11.12%) 0% <0%> (ø)
...ain/java/com/nextcloud/client/logger/LoggerImpl.kt 86.95% <0%> (-2.9%) 0% <0%> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java 42.83% <0%> (-2.34%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.23% <0%> (-1.54%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-1.2%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 28.28% <0%> (-0.91%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 26.31% <0%> (-0.51%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 32.29% <0%> (ø) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 20.52% <0%> (+0.15%) 0% <0%> (ø) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 25.6% <0%> (+0.4%) 0% <0%> (ø) ⬇️

@backportbot-nextcloud
Copy link

backport to stable-3.10 in #5145

tobiasKaminsky added a commit that referenced this pull request Jan 12, 2020
ec515d0 [tx-robot] updated from transifex
422a61d Merge pull request #5136 from nextcloud/systemDefault
6e96e99 Merge pull request #5130 from nextcloud/createRichWorkspace
b7a7772 Merge pull request #5122 from nextcloud/firstRun
603825e update screenshot
c4d5e41 Merge pull request #5143 from nextcloud/background
c6d89ed only allow rich workspace creation on >= Lollipop
87dae2e show first run again
9125285 manually increasing lint due to "autoMirrored" warning
4c10cf5 launcher: correct folder position according to AS
51fdf94 [tx-robot] updated from transifex
e0b77f9 daily dev 20200110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants