add multiple share links #6358
Merged
add multiple share links #6358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Will do 👍 |
AndyScherzinger
force-pushed
the
multipleShareLink
branch
from
922f464 to
8c7d450
Compare
Member
|
❗ @tobiasKaminsky had to rebase to resolve conflicts with master (and fix code analysis gaps) |
AndyScherzinger
force-pushed
the
multipleShareLink
branch
2 times, most recently
from
427892e to
6e6b7b3
Compare
tobiasKaminsky
force-pushed
the
multipleShareLink
branch
from
6e6b7b3 to
5cc8839
Compare
tobiasKaminsky
force-pushed
the
multipleShareLink
branch
from
5cc8839 to
1c57325
Compare
tobiasKaminsky
force-pushed
the
multipleShareLink
branch
from
0d3e4bc to
6ecc100
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
multipleShareLink
branch
from
6ecc100 to
d6b8d6b
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
multipleShareLink
branch
from
d6b8d6b to
f07e14f
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14785.apk |
Collaborator
|
master-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14785-Screenshot-master |
Collaborator
|
stable-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14785-Screenshot-stable |
Collaborator
|
Issues
======
+ Solved 1
Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/providers/FileContentProvider.java 3
- src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java 3
- src/main/java/com/owncloud/android/ui/adapter/PublicShareViewHolder.java 1
- src/main/java/com/owncloud/android/ui/adapter/PublicShareListAdapter.java 1
Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/operations/UpdateShareViaLinkOperation.java -1
+ src/main/java/com/owncloud/android/operations/CreateShareViaLinkOperation.java -4
See the complete overview on Codacy |
Collaborator
Codacy402Lint
SpotBugs (new)
SpotBugs (master)
|
This was referenced Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndyScherzinger as dicussed, would be great if you can polish it a bit ❤️
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests