Add theming logic for share link icons #6400
Conversation
| * @param primaryColor the primary color | ||
| */ | ||
| private getColorForPrimary(int primaryColor) { | ||
| if (Color.BLACK == primaryColor) { |
There was a problem hiding this comment.
Is this obeying dark mode?
There was a problem hiding this comment.
Not at this very moment, we just do this based on the primary color for edge cases and else use the server's text-color value. See also my other comment.
| } else if (Color.WHITE == primaryColor) { | ||
| return Color.BLACK; | ||
| } else { | ||
| return ThemeUtils.fontColor(context, false); |
There was a problem hiding this comment.
Isn't this also a good idea to have this computed on server? font-color-light and font-color dark?
There was a problem hiding this comment.
Don't know, but @nickvergessen might be able to shed some light on the font-color calculations. I'd hope that with a fallback-ing background color working for dark/light the text-color of a button doesn't have any contrast issues anymore. So we would rather have to discuss if primary button texts would have to be white/black or if we just use white in both theme variants.
So also pinging @jancborchardt about this. ATM we don't have text-color variant from the server (also with element-color reference)
There was a problem hiding this comment.
Fine for me to have this in next PR 👍
AndyScherzinger
force-pushed
the
themeIconImagesWithUnicolorBackgrounds
branch
2 times, most recently
from
d1d29bb to
0a41867
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
themeIconImagesWithUnicolorBackgrounds
branch
from
0a41867 to
fd47348
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14836.apk |
|
stable-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
master-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14836-Screenshot-master |
Codacy398Lint
SpotBugs (new)
SpotBugs (master)
|
delete-merged-branch
bot
deleted the
themeIconImagesWithUnicolorBackgrounds
branch
Resolve #6399
As a follow-up for #6332 and #6358 the link icon/background should be themed like the fab/primary-action-buttons now available via the #6332 theming logic.