update: Package signature refactoring#200
Merged
priteshbandi merged 31 commits intonotaryproject:mainfrom Nov 17, 2022
Merged
Conversation
JeyJeyGao
reviewed
Nov 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 73.55% 65.29% -8.26%
==========================================
Files 27 23 -4
Lines 1777 1576 -201
==========================================
- Hits 1307 1029 -278
- Misses 379 477 +98
+ Partials 91 70 -21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Temporary fix for notaryproject/notation-core-go#88 Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
sign
branch
from
5bed925 to
abe962c
Compare
patrickzheng200
force-pushed
the
sign
branch
from
abe962c to
d7c82a3
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Merged
JeyJeyGao
reviewed
Nov 14, 2022
added 2 commits
November 15, 2022 12:00
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
sign
branch
from
e426472 to
e43b292
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
requested changes
Nov 15, 2022
added 3 commits
November 16, 2022 09:35
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 16, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
November 16, 2022 15:57
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 16, 2022
added 3 commits
November 17, 2022 09:59
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
added 2 commits
November 17, 2022 11:26
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files intended to be reviewed in this PR:
(Refactoring of signer package in this PR incorporates the updated plugin and plugin/proto packages.)