doc: add missing username/password options to commands#293
doc: add missing username/password options to commands#293shizhMSFT merged 3 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
===========================================
- Coverage 61.07% 30.64% -30.43%
===========================================
Files 9 25 +16
Lines 280 1612 +1332
===========================================
+ Hits 171 494 +323
- Misses 102 1105 +1003
- Partials 7 13 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dtzar
left a comment
There was a problem hiding this comment.
It would be nice to add to the login section something like: "Once login is completed, then -u -p is no longer required for any notation commands against the registry server authenticated."
|
@yizha1 - since this is just a doc fix and is now at the 1 week mark, I recommend merging it today before notation release. |
Good call, I'll add it. |
Signed-off-by: Binbin Li <libinbin@microsoft.com>
eebfa63 to
0929fd3
Compare
Signed-off-by: Binbin Li <libinbin@microsoft.com>
0929fd3 to
262cc16
Compare
* doc: add missing username/password options to commands (#293) Signed-off-by: Binbin Li <libinbin@microsoft.com> * bump up version to v0.10.0-alpha.3 (#301) * bump up version to v1.0.0-alpha.3 * revise version to v0.10.0-alpha.3 Signed-off-by: Yi Zha <zhayi@outlook.com> * fix: update notation-go (#294) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * Build: Bump dependencies (#306) Signed-off-by: Yi Zha <zhayi@outlook.com> * feat: add weekly release (#282) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Binbin Li <libinbin@microsoft.com> Signed-off-by: Yi Zha <zhayi@outlook.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Binbin Li <libinbin050215@gmail.com> Co-authored-by: Yi Zha <107919912+yizha1@users.noreply.github.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
…#293) Signed-off-by: Binbin Li <libinbin@microsoft.com>
What?
Resovles #276
For commands other than
notation login, we should allow them supportusername/passwordoptions even without first-time logging.Since the
logincommand requirescredentialsStoreset up which might be missing for users. So we cannot force users always useloginto save credentials. Other commands should be able to use the credentials directly from input withoutcredentialsStoreset up.Updated commands:
Signed-off-by: Binbin Li libinbin@microsoft.com