Skip to content

fix: update notation-go#294

Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom
JeyJeyGao:fix/notation_go
Aug 18, 2022
Merged

fix: update notation-go#294
shizhMSFT merged 1 commit intonotaryproject:mainfrom
JeyJeyGao:fix/notation_go

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 10, 2022

This PR updates notation-go to v0.0.0-20220809210532-f0a54093ba32.

  1. update directory structure logic: if config file doesn't exist, create the file at user config directory instead of the system directory;
  2. dir.Path.Localkey signature has been changed and we need to adapt our code.

Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao force-pushed the fix/notation_go branch 2 times, most recently from 709fa30 to ef91f8c Compare August 10, 2022 08:16
@yizha1 yizha1 requested a review from a team August 10, 2022 23:18
@dtzar dtzar added this to the alpha-3 milestone Aug 10, 2022
@dtzar
Copy link
Contributor

dtzar commented Aug 10, 2022

Depends on merge of notaryproject/notation-go#104

@dtzar dtzar added the bug Something isn't working label Aug 10, 2022
@yizha1 yizha1 mentioned this pull request Aug 11, 2022
5 tasks
@gokarnm gokarnm requested a review from rgnote August 11, 2022 19:19
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qmuntal
Copy link
Member

qmuntal commented Aug 16, 2022

I would argue against merging any PR which does not have an appropriate description, even if the changes are small and self-documenting.

For example, this PR could say something like:

This PR updates notation-go to v0.0.0-20220809210532-f0a54093ba32.

The new version does not contain any known bug fix, but dir.Path.Localkey signature has been changed and we need to adapt our code.

@SteveLasker SteveLasker requested review from gokarnm and rgnote August 16, 2022 20:52
@dtzar
Copy link
Contributor

dtzar commented Aug 16, 2022

@rgnote - your feedback has been addressed. Can you please take a quick look? This is the only PR we need to finish alpha.3 release.
@qmuntal - I went ahead and added your description to the PR.

@shizhMSFT shizhMSFT merged commit 44015dc into notaryproject:main Aug 18, 2022
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chloeyin added a commit that referenced this pull request Aug 25, 2022
* doc: add missing username/password options to commands (#293)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* bump up version to v0.10.0-alpha.3 (#301)

* bump up version to v1.0.0-alpha.3
* revise version to v0.10.0-alpha.3

Signed-off-by: Yi Zha <zhayi@outlook.com>

* fix: update notation-go (#294)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* Build: Bump dependencies (#306)

Signed-off-by: Yi Zha <zhayi@outlook.com>

* feat: add weekly release (#282)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Yi Zha <107919912+yizha1@users.noreply.github.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
@JeyJeyGao JeyJeyGao deleted the fix/notation_go branch December 1, 2022 05:59
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

Comments