Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 30.64% 30.64%
=======================================
Files 25 25
Lines 1612 1612
=======================================
Hits 494 494
Misses 1105 1105
Partials 13 13 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Yi Zha <zhayi@outlook.com>
yizha1
force-pushed
the
yizha1/prepare-release
branch
from
7d6ebff to
95fad0d
Compare
internal/version/version.go
Outdated
| var ( | ||
| // Version shows the current notation version, optionally with pre-release. | ||
| Version = "v0.7.1-alpha.1" | ||
| Version = "v1.0.0-alpha.3" |
There was a problem hiding this comment.
We should probably not bump major version to v1.0.0 right now, the alpha releases will have patch updates. Which will bump 1.0.0-{prereleasetag} to 1.0.x-{prereleasetag} and require the v1 release to use the same patch version at some point, this would be bit confusing (e.e. v1.0.5-alpha.3 vs 1.0.5)
https://stackoverflow.com/questions/51373151/releasing-alpha-to-beta-to-production-with-semver
| Version = "v1.0.0-alpha.3" | |
| Version = "v0.8.0-alpha.3" |
gokarnm
left a comment
gokarnm
left a comment
There was a problem hiding this comment.
Suggesting bumping to v0.8.0-alpha.3 instead.
@gokarnm I think it should be v0.9.0-alpha.3. We already released v0.9.0-alpha.1 if you check the release page. The version file was not updated by previous release. |
|
Can we do |
Signed-off-by: Yi Zha <zhayi@outlook.com>
yizha1
changed the title
v0.10.0-alpha.3 is better, since there are features merged, so the minor version should be stepped. |
|
@gokarnm - it is blocked due to your comment not being resolved. You have a LGTM, but no approval. |
* doc: add missing username/password options to commands (#293) Signed-off-by: Binbin Li <libinbin@microsoft.com> * bump up version to v0.10.0-alpha.3 (#301) * bump up version to v1.0.0-alpha.3 * revise version to v0.10.0-alpha.3 Signed-off-by: Yi Zha <zhayi@outlook.com> * fix: update notation-go (#294) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * Build: Bump dependencies (#306) Signed-off-by: Yi Zha <zhayi@outlook.com> * feat: add weekly release (#282) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Binbin Li <libinbin@microsoft.com> Signed-off-by: Yi Zha <zhayi@outlook.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Binbin Li <libinbin050215@gmail.com> Co-authored-by: Yi Zha <107919912+yizha1@users.noreply.github.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
* bump up version to v1.0.0-alpha.3 * revise version to v0.10.0-alpha.3 Signed-off-by: Yi Zha <zhayi@outlook.com>
7 participants
Signed-off-by: Yi Zha zhayi@outlook.com