Sprint5 server backlog by joshmoore · Pull Request #48 · ome/openmicroscopy

joshmoore · 2011-12-28T11:03:05Z

When someone gets the chance, it would be good to start evaluating some of these commits so that before we start the bug work (sprint6) some of this could already be in the mainline.

jburel · 2011-12-28T12:03:06Z

in order to speed up the review, it will good to indicate for some of the commits what to do e.g the compile one

jburel · 2011-12-28T16:40:26Z

Build using that branch. Insight now hangs on Starting Caching Service so the problem is not related to DnD.
java -version java version "1.5.0_28" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_28-b04-382-9M3326) Java HotSpot(TM) 64-Bit Server VM (build 1.5.0_28-157, mixed mode)

jburel · 2011-12-29T07:43:13Z

Hanging problem also happens on develop.

Using ./build.py -Ddist.dir=... no longer works with the insight build since the dist.dir property is copied into the insight build overwriting the expected value. Instead, set the property in etc/local.properties until the insight build has been fully refactored.

With other changes to have dist.dir configurable, it became necessary to merge directories.xml and global.xml so that dist.dir could be set via local.properties before it was used elsewhere.

This also required changing the OMERODIR to point at dist.dir so that the Java and SQL files used in the test could be found.

joshmoore · 2011-12-30T15:06:01Z

To test

`bfced25` "Use getResultsString in ServiceHandler"

Check in the server log when using IQuery.projection for nice output like [[1, 2, 3], [4, 5, 6], [7, 8, 9]] rather than [[Ljava.lang.Object;@50dfc362,...

`5051327` "Use dir.dir for python test with non-default dist"

./build.py build-dev -Ddist.dir=/tmp/my-build-dir should not touch the omero.git/dist at all. Commit 9627d00 was also necessary to make this work. A typo was fixed in a later commit. Further, the insight build does not permit the use of "-Ddist.dir". Instead, set dist.dir in etc/local.properties. A warning message to this effect is printed:

/Users/cblackburn/Work/repos/ome/components/insight/build/dist.xml:57: ERROR: dist.dir is currently set!

        This most likely occurred because dist.dir was set on the top-level
        build:  ./build.py -Ddist.dir=/tmp/example

        This no longer works with the insight build. Instead, set dist.dir
        in the etc/local.properties file.

`3a35d38` "More deletes on 'clean'"

./build.py build-dev; ./build.py clean should leave fewer files lying around.

`a9196bc` "Adding OmeroPy sql directory for testing"

Run the "test/clitest/db.py" test via: ant test -DTEST=clitest.db.

`8d59207` "Disabled test"

Group "broken" wasn't enough to prevent this test from being run. It is now marked "enabled=false".

`ba60d28` "Move ice check to top-level and print help"

If you're using ice 3.3 and not set ice.compatibility=3.3 in etc/local.properties, then rather than waiting until slice2java is executed under components/blitz an error message should be shown right away. (Similarly, if 3.3 is set in local.properties and you are using ice3.4)

`57fefd4` "Fix java 1.6 compile of omero-shares (gh-46)"

If compiling with Java 5, ./build.py build-dev should work. (Previously broken) This was caused by my having just done "javac *.java" under ome/services/sharing/data. The "make_data.py" which I used to create the omero-shares jars now sets the target explicitly.

`63d28eb` "Enable IPython 0.11 shell (Fix #7112)"

With a new IPython installed (pip install ipython) bin/omero shell should work.

joshmoore · 2011-12-30T15:11:38Z

The most important test for the new postgresql jar is to use OMERO against an earlier (especially 8.4) postgresql server.

Setting ice.compatibility is no longer necessary in etc/local.properties. The default value "auto" will use the current value of `slice2java --version`. If a specific value is set, then that will be required.

If omero.version changes between two builds, then an ivy error is printed: {{{ ./build.py OMERO_BUILD=b123 ./build.py ... bad revision found in ivy file (Revision: 4.3.3). Use forcedeliver or update. }}}

Now any build run via ./build.py (or build.bat) will have the current ice version appended to the omero.version value (e.g. 4.3.3-ice34)

A typo in the "check_ice" method was hiding the ctx.die exception. Now, "check_ice" is a top level method: {{{ bin/omero admin checkice }}} and the value of versions.ice rather than ice.compatibility is being saved to omero_versions.py

ximenesuk · 2012-01-11T10:22:54Z

All items now tested okay including the various fixes since the testing began.

Now tested against postgresql 8.3.8

Sprint5 server backlog

2014-SV3+SV4 Robot and Poodle fixes

joshmoore added 8 commits December 20, 2011 10:45

Use getResultsString in ServiceHandler

bfced25

Use dir.dir for python test with non-default dist

5051327

More deletes on 'clean'

3a35d38

Adding OmeroPy sql directory for testing

a9196bc

Disabled test

8d59207

Move ice check to top-level and print help

ba60d28

Fix java 1.6 compile of omero-shares (gh-46)

57fefd4

Enable IPython 0.11 shell (Fix #7112)

63d28eb

Test for getResultsString in ServiceHandlerUnitTest

f762bd1

jburel mentioned this pull request Dec 28, 2011

Dn d manager #46

Merged

joshmoore added 6 commits December 30, 2011 11:47

Remove pdb.set_trace in ipython call

2259f03

Have python tests use local.properties "dist.dir"

5c6fc73

With other changes to have dist.dir configurable, it became necessary to merge directories.xml and global.xml so that dist.dir could be set via local.properties before it was used elsewhere.

Improve clitest/mocks.py and clitest/db.py

49c57fe

This also required changing the OMERODIR to point at dist.dir so that the Java and SQL files used in the test could be found.

Fix stdout issue with db.py while preventing file creation

a74d948

Save db test script to temp rather than stdout

8be4605

postgresql 9.1-901.jdbc3 (Fix #7006)

7c7afe5

chris-allan and others added 8 commits January 2, 2012 11:37

Make LDAP referral handling configurable. (See #7391)

9470775

Change constant.value to constant.ordinal in insight

39a435c

Minor refactoring for speed (See #7711)

eeeab8a

Fix new_client method in Python tests

3466d2a

Prevent BaseException.message warning under Py26

ccbee97

Fix 'lock' referenced before assignment (See #7711)

0ad8841

Auto-detect ice version for artifact names (See #7326)

1e6a5b2

Setting ice.compatibility is no longer necessary in etc/local.properties. The default value "auto" will use the current value of `slice2java --version`. If a specific value is set, then that will be required.

Overwrite ivy files without the need to clean.

3a63e3c

If omero.version changes between two builds, then an ivy error is printed: {{{ ./build.py OMERO_BUILD=b123 ./build.py ... bad revision found in ivy file (Revision: 4.3.3). Use forcedeliver or update. }}}

joshmoore added 4 commits January 10, 2012 09:57

Add ice version to omero.version for non-OMERO_BUILDs too

699aa7a

Now any build run via ./build.py (or build.bat) will have the current ice version appended to the omero.version value (e.g. 4.3.3-ice34)

Fix testng log warning (See ome#2187)

3d9c13d

Fix OmeroPy ice_compatibility during "checkice"

28027f4

A typo in the "check_ice" method was hiding the ctx.die exception. Now, "check_ice" is a top level method: {{{ bin/omero admin checkice }}} and the value of versions.ice rather than ice.compatibility is being saved to omero_versions.py

Fix IPython 0.12 support by passing login ns (See #7112)

9ab9efc

joshmoore added a commit that referenced this pull request Jan 11, 2012

Merge pull request #48 from joshmoore/sprint5-server-backlog

4b3ac95

Sprint5 server backlog

joshmoore merged commit 4b3ac95 into ome:develop Jan 11, 2012

This was referenced Jan 11, 2012

Sprint6 server backlog #56

Closed

Sprint6 server backlog #57

Merged

snoopycrimecop pushed a commit to snoopycrimecop/openmicroscopy that referenced this pull request Nov 19, 2014

Merge pull request ome#48 from sbesson/5_0_6_rebase

367a3d6

2014-SV3+SV4 Robot and Poodle fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sprint5 server backlog#48

Sprint5 server backlog#48
joshmoore merged 28 commits intoome:developfrom
joshmoore:sprint5-server-backlog

joshmoore commented Dec 28, 2011

Uh oh!

jburel commented Dec 28, 2011

Uh oh!

jburel commented Dec 28, 2011

Uh oh!

jburel commented Dec 29, 2011

Uh oh!

joshmoore commented Dec 30, 2011

Uh oh!

joshmoore commented Dec 30, 2011

Uh oh!

ximenesuk commented Jan 11, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joshmoore commented Dec 28, 2011

Uh oh!

jburel commented Dec 28, 2011

Uh oh!

jburel commented Dec 28, 2011

Uh oh!

jburel commented Dec 29, 2011

Uh oh!

joshmoore commented Dec 30, 2011

To test

bfced25 "Use getResultsString in ServiceHandler"

5051327 "Use dir.dir for python test with non-default dist"

3a35d38 "More deletes on 'clean'"

a9196bc "Adding OmeroPy sql directory for testing"

8d59207 "Disabled test"

ba60d28 "Move ice check to top-level and print help"

57fefd4 "Fix java 1.6 compile of omero-shares (gh-46)"

63d28eb "Enable IPython 0.11 shell (Fix #7112)"

Uh oh!

joshmoore commented Dec 30, 2011

Uh oh!

ximenesuk commented Jan 11, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`bfced25` "Use getResultsString in ServiceHandler"

`5051327` "Use dir.dir for python test with non-default dist"

`3a35d38` "More deletes on 'clean'"

`a9196bc` "Adding OmeroPy sql directory for testing"

`8d59207` "Disabled test"

`ba60d28` "Move ice check to top-level and print help"

`57fefd4` "Fix java 1.6 compile of omero-shares (gh-46)"

`63d28eb` "Enable IPython 0.11 shell (Fix #7112)"