Sprint6 server backlog

[joshmoore]

Ongoing bug fixing for sprint6. These tickets are all linked from https://trac.openmicroscopy.org.uk/ome/ticket/7714 In some cases, I'll need to prepare how to test commits (which I'll add here).

@ximenesuk, are you up for continuing on where you left off with gh-48?

[joshmoore]

To test

a3eae6b Run dbPatchCheck before creating sessions (Fix #5216)

Create an old database and start the server against it. Check that the log message is sensible

bin/omero db script OMERO4.1 0 ome
psql old -f OMERO4.1__0.sql
bin/omero config set omero.db.name old
bin/omero admin start

605cd6c Add CloseOnNoSessionContext for handling close (Fix #6639)

Either set session timeouts to a very short time (see #6639) or be patient:

• create a stateful service
• let the session timeout
• call closeSession

Nothing should be logged. This is fairly difficult to test, admittedly; perhaps it suffices that regular stateful functionality is maintained.

c03ee4c Respect -u USER setting from the CLI (Fix #2864)

Try bin/omero -u root login localhost There should be no request for the username, like User [root]:

acbb057 Activate loginAttemptListener and fix test (Fix #6041)

Perhaps re-run test from #6041.

1fb3a0b Minor NPE fix (See #5648)

Turn on ldap. Logins of unknown users should not throw a NPE. (See gretzky for a log file with lots of NPEs)

6c0c5c4 No-op insight and OmeroM tests (See #7257)

Top-level ./build.py test-unit should complete.

45cab53 Passing test for uuid login (See #5648, #6248, etc)

Perhaps re-run tests mentioned.

b7cdfec Delete pixelsOriginalFileMaps for archived images (See #7300)

See ticket. Import an image with "-a" for archiving and then immediately try to delete the file.

1ff6faa Pass DISPLAY environment variable to scripts (Fix #4027)

Set DISPLAY before starting omero. Then run a script that prints out the variable.

export DISPLAY=foo
bin/omero admin start
bin/omero script upload --official test.py
bin/omero script list    ---> shows ID
bin/omero script launch ID

05a95ce Passing test for #2513 (NPE in IShare)

Possibly re-run test in ticket

14c9113 Attempt to fix Windows insight build (See #7734)

Nothing really to test; not yet complete. Optionally run the build under Windows.

9a2870a Apply batchSize to findAllByFullText results (Fix #2762)

Possibly re-run test. Calls to IQuery.findAllByFullText(..., params) should return fewer if limit is set.

5cd1364 Add help message on bad edit (Fix #2845, See #2890)

See console example in ticket. Basically: touch script under lib/scripts that is completely wrong:

raise Exception("this can't work")

bin/omero script list should print the script. Try to edit it with bin/omero script edit ID

This should print the error message shown.

3d6e31d Handle empty return result from findAllByFullText (See #2762)

Empty search result from IQuery.findAllByFullText shouldn't throw an exception.

89193d7 Passing perm search test (See #2541)

Possibly re-reun test.

a7c9f6e Passing IUpdate delete test (See #4341)

Possibly re-run test.

41e952d Failing test of ofile with fileann (See #7314)

Test should fail: still waiting on a decision on the ticket.

[joshmoore]

Testing f82eb76 should be as simple as just running a build on Windows. 6b4b44b needs to be looked into by J-M first.

[joshmoore]

For c301e9f you can see the ticket 7747 as well as the linked ticket which has a sample script. There are also unit tests. The goal is that python won't hang around due to the background thread on a bad login, while still properly keeping sessions alive, which might be tricky to test.

[joshmoore]

Working now on PG 9.0.4 (8.3 and earlier is still not implemented). That's all the commits checked. Anyone else have comment or suggestions before merging?

[joshmoore]

Ok, from Chris as well. Merging.