feat: refactor core module into multiple packages

[thisthat]

Signed-off-by: Giovanni Liva giovanni.liva@dynatrace.com

This PR

• Refactor the service_[connect|metrics].go into multiple files
• Adds more unit tests when easy and feasible

Related Issues

Preparation for #501

[toddbaert]

I like this refactor. In general it's my preference to see refactors done in separate PRs. It's helps to be able to approach a refactor PR knowing there's no functional changes. I'd like to see it separated if possible, but it's not necessary.

[thisthat]

I like this refactor. In general it's my preference to see refactors done in separate PRs. It's helps to be able to approach a refactor PR knowing there's no functional changes. I'd like to see it separated if possible, but it's not necessary.

That's a fair argument. I will remove the impressions and just tackle the refactoring with this PR 👍

[codecov]

Codecov Report

Merging #530 (7e44481) into main (99ba5ec) will increase coverage by 0.50%.
The diff coverage is 71.77%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   66.16%   66.66%   +0.50%     
==========================================
  Files          17       19       +2     
  Lines        2113     2133      +20     
==========================================
+ Hits         1398     1422      +24     
  Misses        651      651              
+ Partials       64       60       -4     

Impacted Files	Coverage Δ
core/pkg/runtime/from_config.go	26.90% <0.00%> (-1.15%)	⬇️
core/pkg/runtime/runtime.go	0.00% <0.00%> (ø)
...kg/service/flag-evaluation/flag_evaluator_types.go	89.65% <ø> (ø)
core/pkg/service/flag-evaluation/flag_evaluator.go	61.81% <61.81%> (ø)
core/pkg/service/middleware/http_metrics.go	76.25% <76.25%> (ø)
...ore/pkg/service/flag-evaluation/connect_service.go	63.63% <94.11%> (+3.77%)	⬆️
core/pkg/otel/metrics.go	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[thisthat]

I need some help with the integration-tests @toddbaert
Locally, they also don't work. The strange thing is that I can reach the binary under test via curl curl -X POST "localhost:8013/schema.v1.Service/ResolveString" -d '{"flagKey":"string-flag","context":{}}' -H "Content-Type: application/json"

[thisthat]

I need some help with the integration-tests @toddbaert Locally, they also don't work. The strange thing is that I can reach the binary under test via curl curl -X POST "localhost:8013/schema.v1.Service/ResolveString" -d '{"flagKey":"string-flag","context":{}}' -H "Content-Type: application/json"

For the record, connect-go requires an implementation of Flush() to work properly. Thanks to @bacherfl to figure it out

[bacherfl]

lgtm