fix: fixing silent lint failures

[Kavindu-Dodan]

This PR

Fix lint check & adds lint fixes for existing lint failures (reason for 16 file changes)

See this example [1], linting was failing silently as we rely on a foreach loop.

Solution credits - https://stackoverflow.com/a/22214424/3197055

[1] - https://github.com/open-feature/flagd/actions/runs/4471193065/jobs/7855746534#step:5:640

[codecov]

Codecov Report

Merging #550 (0781726) into main (41799f6) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   66.66%   66.71%   +0.04%     
==========================================
  Files          19       19              
  Lines        2133     2127       -6     
==========================================
- Hits         1422     1419       -3     
+ Misses        651      648       -3     
  Partials       60       60              

Impacted Files	Coverage Δ
core/pkg/runtime/runtime.go	0.00% <0.00%> (ø)
core/pkg/sync-store/sync_store.go	83.51% <ø> (ø)
core/pkg/sync/grpc/credentials/builder.go	100.00% <ø> (ø)
core/pkg/sync/grpc/grpc_sync.go	90.97% <ø> (ø)
core/pkg/sync/http/http_sync.go	43.29% <0.00%> (ø)
core/pkg/eval/json_evaluator.go	87.72% <100.00%> (-0.17%)	⬇️
...ore/pkg/service/flag-evaluation/connect_service.go	63.63% <100.00%> (ø)
core/pkg/service/flag-evaluation/flag_evaluator.go	61.81% <100.00%> (ø)
core/pkg/service/middleware/http_metrics.go	76.25% <100.00%> (ø)
core/pkg/sync/file/filepath_sync.go	54.54% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[thisthat]

Nice catch 🙌