Skip to content

feat: Introduce kube-proxy-metrics#558

Merged
toddbaert merged 15 commits intoopen-feature:mainfrom
james-milligan:kube-proxy-metrics
Mar 28, 2023
Merged

feat: Introduce kube-proxy-metrics#558
toddbaert merged 15 commits intoopen-feature:mainfrom
james-milligan:kube-proxy-metrics

Conversation

@james-milligan
Copy link
Copy Markdown
Contributor

@james-milligan james-milligan commented Mar 24, 2023

This PR

  • adds framework for exposing metrics for the flagd-kube-proxy
  • exposes sync_active_streams, for use in auto scaling the proxy in deployments

Related Issues

Notes

Follow-up Tasks

How to test

@james-milligan
wip
f85dad7 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
nil pointer fix + export constructors
51b1ac2 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
merge
d5f1cd8 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
cleanup
9f07e33 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
merge
e20b47f 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
fix conflicts
3faddd7 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
Merge branch 'main' into kube-proxy-metrics
aa35c2b
@james-milligan
Merge http://github.com/open-feature/flagd into kube-proxy-metrics
d34f4f6
@james-milligan james-milligan requested a review from a team March 24, 2023 13:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #558 (6044a29) into main (76ec463) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 6044a29 differs from pull request most recent head 7fec20e. Consider uploading reports for the commit 7fec20e to get more accurate results

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   70.92%   71.04%   +0.12%     
==========================================
  Files          21       21              
  Lines        2170     2179       +9     
==========================================
+ Hits         1539     1548       +9     
  Misses        574      574              
  Partials       57       57
Impacted Files Coverage Δ
core/pkg/sync-store/sync_store.go 89.24% <100.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

thisthat
thisthat reviewed Mar 24, 2023
View reviewed changes
Comment thread core/pkg/service/sync/sync_metrics.go Outdated
@james-milligan
switch to otel metric collection with prometheus exporter
39da2c7 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
cleanup
d0691e6 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan
test coverage
c8a1287 
Signed-off-by: James Milligan <james@omnant.co.uk>
skyerus
skyerus reviewed Mar 27, 2023
View reviewed changes
Comment thread core/pkg/service/sync/sync_metrics.go Outdated
@james-milligan
remove unused context
7e1e480 
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan requested a review from thisthat March 27, 2023 14:55
@toddbaert toddbaert self-requested a review March 27, 2023 16:54
toddbaert
toddbaert approved these changes Mar 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you think of other metrics that would be useful, you can add issues to this.

@toddbaert toddbaert merged commit ad0baeb into open-feature:main Mar 28, 2023
@github-actions github-actions Bot mentioned this pull request Mar 28, 2023
Merged
toddbaert added a commit that referenced this pull request Mar 30, 2023
@github-actions @toddbaert
chore: release main (#547)
529e3e9 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.5.0</summary>

##
[0.5.0](flagd/v0.4.5...flagd/v0.5.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* unify sources configuration handling
([#560](#560))

### 🐛 Bug Fixes

* benchmark pipeline
([#538](#538))
([62cc0fc](62cc0fc))
* **deps:** update module github.com/open-feature/flagd/core to v0.4.5
([#552](#552))
([41799f6](41799f6))


### 🧹 Chore

* refactor configuration handling for startup
([#551](#551))
([8dfbde5](8dfbde5))
</details>

<details><summary>flagd-proxy: 0.2.0</summary>

##
[0.2.0](flagd-proxy-v0.1.2...flagd-proxy/v0.2.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))

### ✨ New Features

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
([223de99](223de99))
</details>

<details><summary>core: 0.5.0</summary>

##
[0.5.0](core/v0.4.5...core/v0.5.0)
(2023-03-30)


### ⚠ BREAKING CHANGES

* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
* unify sources configuration handling
([#560](#560))

### 🧹 Chore

* move credential builder for grpc sync into seperate component
([#536](#536))
([7314fee](7314fee))
* refactor configuration handling for startup
([#551](#551))
([8dfbde5](8dfbde5))
* refactor middleware setup in server
([#554](#554))
([01016c7](01016c7))
* refactor service configuration objects
([#545](#545))
([c7b29ed](c7b29ed)),
closes [#524](#524)
* unify sources configuration handling
([#560](#560))
([7f4888a](7f4888a))


### 🐛 Bug Fixes

* **deps:** update module google.golang.org/grpc to v1.54.0
([#548](#548))
([99ba5ec](99ba5ec))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.6
([#572](#572))
([bed9458](bed9458))
* fixing silent lint failures
([#550](#550))
([30c8022](30c8022))
* nil pointer fix + export constructors
([#555](#555))
([78adb81](78adb81))


### ✨ New Features

* expose Impression metric
([#556](#556))
([77e0a33](77e0a33))
* Introduce kube-proxy-metrics
([#558](#558))
([ad0baeb](ad0baeb))
* rename `kube-flagd-proxy` to `flagd-proxy`
([#576](#576))
([223de99](223de99))
* refactor core module into multiple packages
([#530](#530))
([9d68d0b](9d68d0b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
@github-actions github-actions Bot mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toddbaert toddbaert toddbaert approved these changes

@thisthat thisthat Awaiting requested review from thisthat

+1 more reviewer

@skyerus skyerus skyerus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@james-milligan @thisthat @toddbaert @skyerus @beeme1mr