Fix up Tender load order #1375
Merged
Fix up Tender load order #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, except it doesn't work.... |
So that tender_widget.js loads after we've defined window.Tender
Contributor
Author
There was a problem hiding this comment.
Caniuse says that document.getElementsByClassName is supported since IE9, so it's just compatible enough. http://caniuse.com/getelementsbyclassname
Contributor
Author
|
@cahrens Oops! Sorry about that, I've fixed up the PR and tested it this time, so it works now. :) Can you re-review? |
|
👍 Let's push this to the dev sandbox also for today's testing. |
singingwolfboy
added a commit
that referenced
this pull request
Oct 17, 2013
Fix up Tender load order
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 27, 2016
* Implements ga_optional openedx#1239 (openedx#1393) * Fix has_terminated on course-overview. openedx#1324 (openedx#1391) * Version up CourseOverview to regenerate CourseOverview. * Add send_mail option to ContractAuth(biz) openedx#1322 (openedx#1392) * Revert "Revert "Merge pull request openedx#1298 from hachiyanagi-ks/develop/dogwood/…" (openedx#1394) * Version up django and ora2 openedx#1375 (openedx#1396) * Version up to django==1.8.16 openedx#1375 * Version up ora2 to gacco/eucalyptus==1.1.5 openedx#1375 * Add format file openedx#1428 (openedx#1465) * Text correction of scoring by instructor openedx#1467
jamestait
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Mar 4, 2019
* Bump api-integration to 2.5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cahrens