django-admin command for enabling email per course #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@brianhw @dianakhuang can you take a look? I'm still in the middle of writing tests for |
Contributor
|
The admin stuff looks good to me. |
lms/djangoapps/bulk_email/models.py
Outdated
Contributor
There was a problem hiding this comment.
Why are these uniqued together? I would assume that there would be one entry for each course_id, and that course_id might have a flag value that is either false or true. This way it would allow an entry for course_id that is true, and a second entry that is set to false.
Contributor
|
Just a few comments -- looks good. |
sarina
added a commit
that referenced
this pull request
Oct 11, 2013
django-admin command for enabling email per course
Closed
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 27, 2016
* Implements ga_optional openedx#1239 (openedx#1393) * Fix has_terminated on course-overview. openedx#1324 (openedx#1391) * Version up CourseOverview to regenerate CourseOverview. * Add send_mail option to ContractAuth(biz) openedx#1322 (openedx#1392) * Revert "Revert "Merge pull request openedx#1298 from hachiyanagi-ks/develop/dogwood/…" (openedx#1394) * Version up django and ora2 openedx#1375 (openedx#1396) * Version up to django==1.8.16 openedx#1375 * Version up ora2 to gacco/eucalyptus==1.1.5 openedx#1375 * Add format file openedx#1428 (openedx#1465) * Text correction of scoring by instructor openedx#1467
giovannicimolin
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a django-admin feature to restrict access to the bulk email feature to those we explicitly grant access.
This PR:
Both beta dash and legacy dash email tabs are gated in this manner.