hotfix/Adam/disable accounts 2 #1298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2013 16:06
when draft is deleted and then parent published. ensure moving doesn't cause deletion
common/djangoapps/student/models.py
Outdated
Contributor
There was a problem hiding this comment.
No need for the strings to be that short! :)
Contributor
Author
There was a problem hiding this comment.
I'm just going by the django docs (https://docs.djangoproject.com/en/1.5/ref/models/fields/#choices). What would be more appropriate? Something like "AC_DIS" or "AC_EN"?
Contributor
There was a problem hiding this comment.
The choices strings can be anything you want. The examples in the docs are two-letter all caps, but there's no need for them to be. I would choose "disabled" and "enabled". The values will only be seen by people examining the db manually, and it would be great if there were values there that they could understand.
Delete on publish to prevent orphans
…aptions. Front-end functionality was not removed. When flag is set to "True", old behaviour of autohiding of controls and captions will be enabled.
When auto-show/auto-hide is disabled, the captions will be shown when the user will move the mouse over the "CC" button. They will then auto-hide after a while if the user doesn't continue to move the mouse over the "CC" button, or over the captions themselves, or use the keyboard to select a specific caption. If the mouse pointer is not over the captions or the "CC" button, they will hide after a while. This is the key in the fix for bug BLD-355: Transcript hovers over over videoplayer itself for PKU videos.
…ts that needed it.
LMS: Revised CSS Architecture (resolves LMS_1020)
Bulk Email improvements for release
common/djangoapps/student/views.py
Outdated
Contributor
There was a problem hiding this comment.
Log messages shouldn't be internationalized.
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
add migration
add middleware to detect students with disabled accounts add tests
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 20, 2016
…ix-task-atomic Fix transaction span for ga_task
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 20, 2016
…ogwood/fix-task-atomic" (openedx#1333) This reverts commit c0332b9, reversing changes made to 7db6319.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 27, 2016
* Implements ga_optional openedx#1239 (openedx#1393) * Fix has_terminated on course-overview. openedx#1324 (openedx#1391) * Version up CourseOverview to regenerate CourseOverview. * Add send_mail option to ContractAuth(biz) openedx#1322 (openedx#1392) * Revert "Revert "Merge pull request openedx#1298 from hachiyanagi-ks/develop/dogwood/…" (openedx#1394) * Version up django and ora2 openedx#1375 (openedx#1396) * Version up to django==1.8.16 openedx#1375 * Version up ora2 to gacco/eucalyptus==1.1.5 openedx#1375 * Add format file openedx#1428 (openedx#1465) * Text correction of scoring by instructor openedx#1467
giovannicimolin
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Dec 20, 2018
…ete-imexp-on-submit Bump image explorer version to 1.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nedbat @cpennington
This PR does:
@wedaly the failures with the video caption tests are known issues, right?