Skip to content

OCPBUGS-28230: add FallbackToLogsOnError for easier debugging#672

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
deads2k:termination-2
Feb 7, 2024
Merged

OCPBUGS-28230: add FallbackToLogsOnError for easier debugging#672
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
deads2k:termination-2

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Feb 5, 2024

All openshift operators must include FallbackToLogsOnError to ease debugging.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 5, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dlom and lleshchi February 5, 2024 23:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b3a050) 48.42% compared to head (d3af77d) 48.70%.
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   48.42%   48.70%   +0.28%     
==========================================
  Files          96       96              
  Lines       11776    11934     +158     
==========================================
+ Hits         5702     5813     +111     
- Misses       5442     5484      +42     
- Partials      632      637       +5     
Files Coverage Δ
pkg/assets/v410_00_assets/bindata.go 46.96% <ø> (ø)

... and 2 files with indirect coverage changes

@jstuever
Copy link
Copy Markdown
Contributor

jstuever commented Feb 6, 2024

/assign

@jstuever
Copy link
Copy Markdown
Contributor

jstuever commented Feb 6, 2024

/test e2e-azure

Copy link
Copy Markdown
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 7, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit ca92b8d into openshift:master Feb 7, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state.

Details

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202402070113.p0.gca92b8d.assembly.stream.el8 for distgit ose-cloud-credential-operator.
All builds following this will include this PR.

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
OCPBUGS-28230: add FallbackToLogsOnError for easier debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants