Skip to content

Revert "OCPBUGS-28230: enforce termination message policy on all platform pods"#28721

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
neisw:revert-28547-termination
Apr 18, 2024
Merged

Revert "OCPBUGS-28230: enforce termination message policy on all platform pods"#28721
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
neisw:revert-28547-termination

Conversation

@neisw
Copy link
Copy Markdown
Contributor

@neisw neisw commented Apr 18, 2024

Reverts #28547

Capturing one off namespaces (must-gather in this case) causes aggregation to fail.

4.16.0-0.ci-2024-04-18-054948

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@neisw: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #28547

Capturing one off namespaces (must-gather) the cause aggregation to fail.

4.16.0-0.ci-2024-04-18-054948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial April 18, 2024 14:29
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [DennisPeriquet,neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD e5c2630 and 2 for PR HEAD d11bb58 in total

@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented Apr 18, 2024

/override ci/prow/e2e-aws-ovn-serial

want to get the revert in before the next payloads kick off.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 18, 2024

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-serial

want to get the revert in before the next payloads kick off.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented Apr 18, 2024

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 18, 2024

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5ac6743 into openshift:master Apr 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@neisw: Jira Issue OCPBUGS-28230: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28230 has been moved to the MODIFIED state.

Details

In response to this:

Reverts #28547

Capturing one off namespaces (must-gather in this case) causes aggregation to fail.

4.16.0-0.ci-2024-04-18-054948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 18, 2024

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi d11bb58 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-upgrade d11bb58 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-sdn d11bb58 link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404181812.p0.g5ac6743.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants