Skip to content

OCPBUGS-28230: Add terminationMessagePolicy to all containers#216

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jsafrane:add-termination-policy
Apr 18, 2024
Merged

OCPBUGS-28230: Add terminationMessagePolicy to all containers#216
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jsafrane:add-termination-policy

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Apr 17, 2024

For easier debugging. And it's required in OCP operators.

@openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 17, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2024

@jsafrane: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

For easier debugging. And it's required in OCP operators.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Apr 17, 2024

/retest-required

@jsafrane jsafrane force-pushed the add-termination-policy branch from a66c70e to 465367c Compare April 17, 2024 12:53
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
bertinatto
bertinatto reviewed Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2024

/retest-required

Remaining retests: 0 against base HEAD d7e1d3c and 2 for PR HEAD 465367c in total

@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Apr 17, 2024

/retest

failed to acquire lease for "azure4-quota-slice": status 403 Forbidden, status code 403

deads2k
deads2k reviewed Apr 17, 2024
View reviewed changes
Comment thread assets/common/sidecars/attacher.yaml Outdated
- name: csi-attacher
image: ${ATTACHER_IMAGE}
imagePullPolicy: IfNotPresent
terminationMessagePolicy: FallbackToLogsOnError
Copy link
Copy Markdown
Contributor

@deads2k deads2k Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this already set here: https://github.com/openshift/csi-operator/blob/master/assets/common/sidecars/attacher.yaml#L28 ?

Copy link
Copy Markdown
Contributor Author

@jsafrane jsafrane Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! Fixed in all sidecars + CSI driver containers

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2024

/retest-required

Remaining retests: 0 against base HEAD ef2c2ec and 1 for PR HEAD 465367c in total

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 18, 2024
Merged
@jsafrane
Add terminationMessagePolicy to all containers
42de757 
For easier debugging. And it's required in OCP operators.
@jsafrane jsafrane force-pushed the add-termination-policy branch from 465367c to 42de757 Compare April 18, 2024 08:36
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 18, 2024

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 42de757 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 18, 2024

hoping this fixes most of the rest: https://search.dptools.openshift.org/?search=must+have+terminationMessagePolicy%3D%22FallbackToLogsOnError%22&maxAge=48h&context=1&type=bug%2Bissue%2Bjunit&name=4.16&excludeName=upgrade%7Cpull&maxMatches=5&maxBytes=20971520&groupBy=job

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 097858b into openshift:master Apr 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 18, 2024

@jsafrane: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state.

Details

In response to this:

For easier debugging. And it's required in OCP operators.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 18, 2024
Merged
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 18, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.16.0-202404181209.p0.g097858b.assembly.stream.el9 for distgit azure-file-csi-driver-operator.
All builds following this will include this PR.

This was referenced Apr 18, 2024
Merged
Merged
Merged
Merged
This was referenced Apr 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

+1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsafrane @openshift-ci-robot @deads2k @openshift-bot @bertinatto