Skip to content

/pkg/cvo: improve CV history pruning#805

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jottofar:ota-662
Aug 15, 2022
Merged

/pkg/cvo: improve CV history pruning#805
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jottofar:ota-662

Conversation

@jottofar
Copy link
Copy Markdown
Contributor

@jottofar jottofar commented Jul 27, 2022 •
edited
Loading

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@openshift-ci openshift-ci Bot requested review from LalatenduMohanty and wking July 27, 2022 21:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@jottofar jottofar force-pushed the ota-662 branch 6 times, most recently from 14bda3d to 3825a85 Compare August 3, 2022 16:26
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 3, 2022

/retitle /pkg/cvo: improve CV history pruning

@openshift-ci openshift-ci Bot changed the title WIP: /pkg/cvo: improve CV history pruning /pkg/cvo: improve CV history pruning Aug 3, 2022
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 3, 2022

/retest

1 similar comment
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 3, 2022

/retest

wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history_test.go Outdated
wking
wking reviewed Aug 4, 2022
View reviewed changes
Comment thread pkg/cvo/status_history_test.go
wking
wking approved these changes Aug 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 15, 2022

/retest-required

Remaining retests: 2 against base HEAD c699d55 and 8 for PR HEAD 76efa28 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 15, 2022

/retest-required

Remaining retests: 1 against base HEAD c699d55 and 7 for PR HEAD 76efa28 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 348add6 into openshift:master Aug 15, 2022
@wking wking mentioned this pull request Aug 30, 2022
Merged
@wking
Copy link
Copy Markdown
Member

wking commented Aug 30, 2022

There's a bugfix in #828. We're unlikely to backport this particular change, but commenting here in case we change our minds, so we remember to backport both this and the fix.

@wking wking mentioned this pull request May 8, 2023
Closed
@wking wking mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jottofar @openshift-ci-robot @wking @openshift-merge-robot