OCPBUGS-569: CVO History Pruner return not assigned to config.Status.History

[evakhoni]

reported in OCPBUGS-569, cvo history method prune return is not assigned to status.history, resulting in history not being pruned, and prune method running in loops as seen in cvo log:

cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:37.889213       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:52.886216       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:07.887131       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:22.886281       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:37.888316       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.

tested on cluster bot build with 100 upgrade and rollback cycles. before the fix the history grown beyond 100, and cvo log contained multiple prune messages trying to prune. with the fix, in the last cycle cvo successfully pruned (the oldest partial history[-2] in this case) item, and there was 1 pruning message only in cvo log, as expected:

╰─ grep Pruning *.log
cluster-version-operator-9b9868b46-mm2rw.log:I0826 12:22:58.871969       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.ci.test-2022-08-26-112653-ci-ln-cm0zivt-latest at index 99 with rank -99.990000.

[openshift-ci]

@evakhoni: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@evakhoni: This pull request references [Jira Issue OCPBUGS-569](https://issues.redhat.com//browse/OCPBUGS-569), which is invalid:

• expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@evakhoni: This pull request references [Jira Issue OCPBUGS-569](https://issues.redhat.com//browse/OCPBUGS-569), which is invalid:

• expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

reported in OCPBUGS-569, cvo history method prune return is not assigned to status.history, resulting in history not being pruned, and prune method running in loops as seen in cvo log.

tested on cluster bot build with 100 upgrade and rollback cycles. before the fix the history grown beyond 100, and cvo log contained multiple prune messages trying to prune. with the fix, in the last cycle cvo successfully pruned (the oldest partial history[-2] in this case) item, and there was 1 pruning message only in cvo log, as expected:

╰─ grep Pruning *.log
cluster-version-operator-9b9868b46-mm2rw.log:I0826 12:22:58.871969       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.ci.test-2022-08-26-112653-ci-ln-cm0zivt-latest at index 99 with rank -99.990000.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@evakhoni: This pull request references [Jira Issue OCPBUGS-569](https://issues.redhat.com//browse/OCPBUGS-569), which is invalid:

• expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

reported in OCPBUGS-569, cvo history method prune return is not assigned to status.history, resulting in history not being pruned, and prune method running in loops as seen in cvo log:

cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:37.889213       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:52.886216       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:07.887131       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:22.886281       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:37.888316       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.

tested on cluster bot build with 100 upgrade and rollback cycles. before the fix the history grown beyond 100, and cvo log contained multiple prune messages trying to prune. with the fix, in the last cycle cvo successfully pruned (the oldest partial history[-2] in this case) item, and there was 1 pruning message only in cvo log, as expected:

╰─ grep Pruning *.log
cluster-version-operator-9b9868b46-mm2rw.log:I0826 12:22:58.871969       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.ci.test-2022-08-26-112653-ci-ln-cm0zivt-latest at index 99 with rank -99.990000.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[evakhoni]

/jira refresh

[openshift-ci-robot]

@evakhoni: This pull request references Jira Issue OCPBUGS-569, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @evakhoni

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: evakhoni.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@evakhoni: This pull request references Jira Issue OCPBUGS-569, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @evakhoni

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evakhoni, jottofar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@evakhoni: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#828

Jira Issue OCPBUGS-569 has been moved to the MODIFIED state.

Details

In response to this:

reported in OCPBUGS-569, cvo history method prune return is not assigned to status.history, resulting in history not being pruned, and prune method running in loops as seen in cvo log:

cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:37.889213       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:24:52.886216       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:07.887131       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:22.886281       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.
cluster-version-operator-669594b4cd-h89ch.log:I0824 13:25:37.888316       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.nightly-2022-08-23-223922 at index 99 with rank -99.990000.

tested on cluster bot build with 100 upgrade and rollback cycles. before the fix the history grown beyond 100, and cvo log contained multiple prune messages trying to prune. with the fix, in the last cycle cvo successfully pruned (the oldest partial history[-2] in this case) item, and there was 1 pruning message only in cvo log, as expected:

╰─ grep Pruning *.log
cluster-version-operator-9b9868b46-mm2rw.log:I0826 12:22:58.871969       1 status_history.go:69] Pruning an older update of less importance version 4.12.0-0.ci.test-2022-08-26-112653-ci-ln-cm0zivt-latest at index 99 with rank -99.990000.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.